xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 01/13] Tcl: Use lshift instead of open-coding with lrange
Date: Wed, 2 Sep 2015 16:45:07 +0100	[thread overview]
Message-ID: <1441208719-31336-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1441208719-31336-1-git-send-email-ian.jackson@eu.citrix.com>

In ms-queuedaemon, and JobDB-Executive, once each.  No functional
change.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ms-queuedaemon          |    3 +--
 tcl/JobDB-Executive.tcl |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/ms-queuedaemon b/ms-queuedaemon
index e15bc79..d6d59ee 100755
--- a/ms-queuedaemon
+++ b/ms-queuedaemon
@@ -210,8 +210,7 @@ proc queuerun-perhaps-step {} {
         return
     }
 
-    set thinking [lindex $queue_running 0]
-    set queue_running [lrange $queue_running 1 end]
+    set thinking [lshift queue_running]
     log-event "queuerun-perhaps-step selected"
 
     set thinking_after [after [expr {$c(QueueThoughtsTimeout) * 1000}] \
diff --git a/tcl/JobDB-Executive.tcl b/tcl/JobDB-Executive.tcl
index 7228712..d61d2a2 100644
--- a/tcl/JobDB-Executive.tcl
+++ b/tcl/JobDB-Executive.tcl
@@ -74,8 +74,7 @@ proc set-flight {} {
         set argv [lrange $argv 2 end]
     }
 
-    set flight [lindex $argv 0]
-    set argv [lrange $argv 1 end]
+    set flight [lshift argv]
     set env(OSSTEST_FLIGHT) $flight
 }
 
-- 
1.7.10.4

  reply	other threads:[~2015-09-02 15:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 15:45 [OSSTEST RFC PATCH 00/13] Planner: Performance improvement Ian Jackson
2015-09-02 15:45 ` Ian Jackson [this message]
2015-09-03 10:44   ` [OSSTEST PATCH 01/13] Tcl: Use lshift instead of open-coding with lrange Ian Campbell
2015-09-03 10:50     ` Ian Jackson
2015-09-02 15:45 ` [OSSTEST PATCH 02/13] Planner: docs: Minor fixes Ian Jackson
2015-09-03 10:47   ` Ian Campbell
2015-09-03 12:04     ` Ian Jackson
2015-09-02 15:45 ` [OSSTEST PATCH 03/13] Planner: docs: Document set-info command Ian Jackson
2015-09-03 10:48   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 04/13] Planner: Fix indefinite holdoff Ian Jackson
2015-09-03 10:51   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 05/13] Planner: client side: $mayalloc parameter to $resourcecall->() Ian Jackson
2015-09-03 10:52   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 06/13] Planner: client side: New `!OK think noalloc' protocol Ian Jackson
2015-09-03 10:53   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 07/13] Planner: ms-planner support -w option Ian Jackson
2015-09-03 11:25   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 08/13] Planner: ms-queuedaemon: Prep for multiple walkers Ian Jackson
2015-09-03 12:05   ` Ian Campbell
2015-09-03 15:42     ` Ian Jackson
2015-09-02 15:45 ` [OSSTEST PATCH 09/13] Planner: ms-queuedaemon: Synchronise thinking " Ian Jackson
2015-09-03 12:06   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 10/13] Planner: ms-queuedaemon: Break out queuerun-finished/<walker> Ian Jackson
2015-09-03 12:43   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 11/13] Planner: ms-queuedaemon: Break out notify-to-think Ian Jackson
2015-09-03 12:44   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 12/13] Planner: ms-queuedaemon: Make report-plan take output walker name Ian Jackson
2015-09-03 12:44   ` Ian Campbell
2015-09-02 15:45 ` [OSSTEST PATCH 13/13] Planner: ms-queuedaemon: Restart planning when resources become free Ian Jackson
2015-09-03 12:59   ` Ian Campbell
2015-09-03 11:49 ` [OSSTEST PATCH 14/13] Planning reports: Break out return-plan-to-client Ian Jackson
2015-09-03 11:49   ` [OSSTEST PATCH 15/13] Plan reporting: Provide get-last-plan queuedaemon command Ian Jackson
2015-09-03 13:05     ` Ian Campbell
2015-09-03 15:51       ` Ian Jackson
2015-09-03 15:52         ` Ian Jackson
2015-09-03 16:12           ` Ian Campbell
2015-09-03 13:01   ` [OSSTEST PATCH 14/13] Planning reports: Break out return-plan-to-client Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441208719-31336-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).