Re: [OSSTEST PATCH 01/13] Tcl: Use lshift instead of open-coding with lrange

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-09-02 at 16:45 +0100, Ian Jackson wrote:
> In ms-queuedaemon, and JobDB-Executive, once each.  No functional
> change.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

(Caveat: I don't speak a lot of tcl, but seems plausible. Same caveat for
all tcl patches here...)

> ---
>  ms-queuedaemon          |    3 +--
>  tcl/JobDB-Executive.tcl |    3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ms-queuedaemon b/ms-queuedaemon
> index e15bc79..d6d59ee 100755
> --- a/ms-queuedaemon
> +++ b/ms-queuedaemon
> @@ -210,8 +210,7 @@ proc queuerun-perhaps-step {} {
>          return
>      }
>  
> -    set thinking [lindex $queue_running 0]
> -    set queue_running [lrange $queue_running 1 end]
> +    set thinking [lshift queue_running]
>      log-event "queuerun-perhaps-step selected"
>  
>      set thinking_after [after [expr {$c(QueueThoughtsTimeout) * 1000}] \
> diff --git a/tcl/JobDB-Executive.tcl b/tcl/JobDB-Executive.tcl
> index 7228712..d61d2a2 100644
> --- a/tcl/JobDB-Executive.tcl
> +++ b/tcl/JobDB-Executive.tcl
> @@ -74,8 +74,7 @@ proc set-flight {} {
>          set argv [lrange $argv 2 end]
>      }
>  
> -    set flight [lindex $argv 0]
> -    set argv [lrange $argv 1 end]
> +    set flight [lshift argv]
>      set env(OSSTEST_FLIGHT) $flight
>  }
>