xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 2/2] cr-daily-branch: Make sg-report-flight ignore bisections
Date: Thu, 3 Sep 2015 11:45:40 +0100	[thread overview]
Message-ID: <1441277141-7070-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1441277141-7070-1-git-send-email-ian.jackson@eu.citrix.com>

sg-report-flight when testing X' (with a baseline of X) can justify a
failure of T(X',Y,Z) with a bisection failure of T(X,Y'',Z).

If Y'' breaks T then this makes it look to sg-report-flight like T was
already broken in X; cr-daily-branch could then push X' even though it
is actually broken.

This happened rarely, because cr-daily-branch's sg-report-flight would
only look at flights on the right branch, so only a bisection of T on
that branch can cause this, but nevertheless this can produce bad
pushes.

So: have cr-daily-branch pass a --blessings option to cr-daily-branch,
so that it only looks at (usually) `real' rather than the default of
`real' and also `real-bisect'.

An alternative, more complicated, approach would be for
sg-report-flight to compare versions of Y, Z, et al, when looking for
justifications, but I'm not sure this is desirable because it would
effectively reset the heisenbug compensator each time any other tree
changed.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 cr-daily-branch |    1 +
 1 file changed, 1 insertion(+)

diff --git a/cr-daily-branch b/cr-daily-branch
index e90919d..e4c5532 100755
--- a/cr-daily-branch
+++ b/cr-daily-branch
@@ -76,6 +76,7 @@ case $branch in
 esac
 
 blessings_arg=--blessings=${DAILY_BRANCH_TESTED_BLESSING:-$OSSTEST_BLESSING}
+sgr_args+=" $blessings_arg"
 
 force_baseline=false
 skipidentical=true
-- 
1.7.10.4

  reply	other threads:[~2015-09-03 10:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 17:24 [linux-4.1 test] 60785: tolerable FAIL - PUSHED osstest service owner
2015-09-03  8:59 ` Analysis: switch osstest default kernel from 3.14 to 4.1 (Was: Re: [linux-4.1 test] 60785: tolerable FAIL - PUSHED) Ian Campbell
2015-09-21 12:47   ` Ian Campbell
2015-11-17 14:28     ` Ian Campbell
2015-11-17 14:29       ` [PATCH OSSTEST] ap-common: Switch default Linux branch to linux-4.1 Ian Campbell
2015-09-03  9:47 ` [linux-4.1 test] 60785: tolerable FAIL - PUSHED Ian Campbell
2015-09-03 10:05   ` Jan Beulich
2015-09-03 10:34   ` Ian Jackson
2015-09-03 10:45     ` [OSSTEST PATCH 1/2] cr-daily-branch: Break out blessings_arg variable Ian Jackson
2015-09-03 10:45       ` Ian Jackson [this message]
2015-09-03 16:42         ` [OSSTEST PATCH 2/2] cr-daily-branch: Make sg-report-flight ignore bisections Ian Campbell
2015-09-03 16:41       ` [OSSTEST PATCH 1/2] cr-daily-branch: Break out blessings_arg variable Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441277141-7070-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).