From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [OSSTEST PATCH 2/2] cr-daily-branch: Make sg-report-flight ignore bisections Date: Thu, 3 Sep 2015 11:45:40 +0100 Message-ID: <1441277141-7070-2-git-send-email-ian.jackson@eu.citrix.com> References: <21992.8751.727909.610549@mariner.uk.xensource.com> <1441277141-7070-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXS1g-0000sc-R7 for xen-devel@lists.xenproject.org; Thu, 03 Sep 2015 10:45:52 +0000 In-Reply-To: <1441277141-7070-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xenproject.org Cc: Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org sg-report-flight when testing X' (with a baseline of X) can justify a failure of T(X',Y,Z) with a bisection failure of T(X,Y'',Z). If Y'' breaks T then this makes it look to sg-report-flight like T was already broken in X; cr-daily-branch could then push X' even though it is actually broken. This happened rarely, because cr-daily-branch's sg-report-flight would only look at flights on the right branch, so only a bisection of T on that branch can cause this, but nevertheless this can produce bad pushes. So: have cr-daily-branch pass a --blessings option to cr-daily-branch, so that it only looks at (usually) `real' rather than the default of `real' and also `real-bisect'. An alternative, more complicated, approach would be for sg-report-flight to compare versions of Y, Z, et al, when looking for justifications, but I'm not sure this is desirable because it would effectively reset the heisenbug compensator each time any other tree changed. Signed-off-by: Ian Jackson --- cr-daily-branch | 1 + 1 file changed, 1 insertion(+) diff --git a/cr-daily-branch b/cr-daily-branch index e90919d..e4c5532 100755 --- a/cr-daily-branch +++ b/cr-daily-branch @@ -76,6 +76,7 @@ case $branch in esac blessings_arg=--blessings=${DAILY_BRANCH_TESTED_BLESSING:-$OSSTEST_BLESSING} +sgr_args+=" $blessings_arg" force_baseline=false skipidentical=true -- 1.7.10.4