From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 2/2] cr-daily-branch: Make sg-report-flight ignore bisections Date: Thu, 3 Sep 2015 17:42:39 +0100 Message-ID: <1441298559.26292.405.camel@citrix.com> References: <21992.8751.727909.610549@mariner.uk.xensource.com> <1441277141-7070-1-git-send-email-ian.jackson@eu.citrix.com> <1441277141-7070-2-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXXot-0004nP-42 for xen-devel@lists.xenproject.org; Thu, 03 Sep 2015 16:57:03 +0000 In-Reply-To: <1441277141-7070-2-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-09-03 at 11:45 +0100, Ian Jackson wrote: > sg-report-flight when testing X' (with a baseline of X) can justify a > failure of T(X',Y,Z) with a bisection failure of T(X,Y'',Z). > > If Y'' breaks T then this makes it look to sg-report-flight like T was > already broken in X; cr-daily-branch could then push X' even though it > is actually broken. > > This happened rarely, because cr-daily-branch's sg-report-flight would > only look at flights on the right branch, so only a bisection of T on > that branch can cause this, but nevertheless this can produce bad > pushes. > > So: have cr-daily-branch pass a --blessings option to cr-daily-branch, > so that it only looks at (usually) `real' rather than the default of > `real' and also `real-bisect'. > > An alternative, more complicated, approach would be for > sg-report-flight to compare versions of Y, Z, et al, when looking for > justifications, but I'm not sure this is desirable because it would > effectively reset the heisenbug compensator each time any other tree > changed. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell