From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] x86/NUMA: make init_node_heap() respect Xen heap limit Date: Fri, 4 Sep 2015 13:57:26 +0100 Message-ID: <1441371446.26292.492.camel@citrix.com> References: <55DEE85D020000780009D4FA@prv-mh.provo.novell.com> <55E8A716.3080109@citrix.com> <55E8B45A.2040909@citrix.com> <55E96652020000780009F81F@prv-mh.provo.novell.com> <1441355255.26292.417.camel@citrix.com> <55E974C7020000780009F8A4@prv-mh.provo.novell.com> <1441356769.26292.430.camel@citrix.com> <55E97BD8020000780009F8D5@prv-mh.provo.novell.com> <55E980B7.4090100@citrix.com> <55E9A474020000780009FA14@prv-mh.provo.novell.com> <55E99391.6000501@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZXqZ1-0006Jd-Lo for xen-devel@lists.xenproject.org; Fri, 04 Sep 2015 12:57:55 +0000 In-Reply-To: <55E99391.6000501@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , Jan Beulich Cc: Wei Liu , Stefano Stabellini , Andrew Cooper , TimDeegan , xen-devel , KeirFraser , IanJackson List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-04 at 13:50 +0100, Julien Grall wrote: > On 04/09/15 13:02, Jan Beulich wrote: > > > > > On 04.09.15 at 13:29, wrote: > > > Anyway, I tried your suggestion to dropped the call to > > > xenheap_max_mfn when > > > Xen > > > setups the xenheap for arm64 and it allows me to boot correctly Xen > > > on > > > X-gene. > > > See patch below, I can send the patch in a separate thread if > > > necessary. > > > > That would depend on Ian and Wei - to me it looks okay this way, > > perhaps minus the title wanting to be re-written. > > I took the previous commit message and rewrite it a bit but forgot to > update the title. How about: > > "xen/arm64: Remove call to xenheap_max_mfn when setup the xenheap" WFM and my ack would apply with this in place too. (s/setup/setting up/ if I were feeling pedantic) > > > > commit b11ab8e4982228d7944e11010f5b8eec890caf30 > > > Author: Julien Grall > > > Date: Thu Sep 3 21:49:31 2015 +0100 > > > > > > xen: pagealloc: Correctly calculate the number of xenheap bits > > > > > > The commit 88e3ed61642bb393458acc7a9bd2f96edc337190 "x86/NUMA: > > > make > > > init_node_heap() respect Xen heap limit" breaks boot on the arm64 > > > board > > > X-Gene. > > > > > > The xenheap bits variable is used to know the last RAM MFN always > > > mapped > > > in Xen virtual memory. If the value is 0, it means that all the > > > memory is > > > always mapped in Xen virtual memory. > > > > > > On X-gene the RAM bank resides above 128GB and last xenheap MFN > > > is > > > 0x4400000. With the new way to calculate the number of bits, > > > xenheap_bits > > > will be equal to 38 bits. This will result to hide all the RAM > > > and the > > > impossibility to allocate xenheap memory. > > > > > > Given that aarch64 have always all the memory mapped in Xen > > > virtual > > > memory, it's not necessary to call xenheap_max_mfn which set the > > > number > > > of bits. > > > > > > Suggested-by: Jan Beulich > > > Signed-off-by: Julien Grall > > > > > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > > > index 6626eba..48f734f 100644 > > > --- a/xen/arch/arm/setup.c > > > +++ b/xen/arch/arm/setup.c > > > @@ -665,7 +665,6 @@ static void __init setup_mm(unsigned long > > > dtb_paddr, size_t dtb_size) > > > xenheap_virt_end = XENHEAP_VIRT_START + ram_end - ram_start; > > > xenheap_mfn_start = ram_start >> PAGE_SHIFT; > > > xenheap_mfn_end = ram_end >> PAGE_SHIFT; > > > - xenheap_max_mfn(xenheap_mfn_end); > > > > > > /* > > > * Need enough mapped pages for copying the DTB. > > > -- > > > Julien Grall > > > > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > > >