From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Tamas K Lengyel <tamas@tklengyel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH for 4.6] tools/xen-access: use PRI_xen_pfn
Date: Fri, 4 Sep 2015 15:40:44 +0100 [thread overview]
Message-ID: <1441377644.26292.523.camel@citrix.com> (raw)
In-Reply-To: <1441304867-20284-1-git-send-email-wei.liu2@citrix.com>
On Thu, 2015-09-03 at 19:27 +0100, Wei Liu wrote:
> Otherwise when building with 32bit compiler, we get:
>
> xen-access.c: In function 'xenaccess_init':
> xen-access.c:263:5: error: format '%llx' expects argument of type 'long
> long unsigned int', but argument 3 has type 'xen_pfn_t' [-Werror=format]
> cc1: all warnings being treated as errors
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Applied with both acks.
> ---
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Cc: Tamas K Lengyel <tamas@tklengyel.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> ---
> tools/tests/xen-access/xen-access.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen
> -access/xen-access.c
> index cdb8f4e..a52ca6e 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -260,7 +260,7 @@ xenaccess_t *xenaccess_init(xc_interface **xch_r,
> domid_t domain_id)
> goto err;
> }
>
> - DPRINTF("max_gpfn = %"PRIx64"\n", xenaccess->max_gpfn);
> + DPRINTF("max_gpfn = %"PRI_xen_pfn"\n", xenaccess->max_gpfn);
>
> return xenaccess;
>
prev parent reply other threads:[~2015-09-04 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 18:27 [PATCH for 4.6] tools/xen-access: use PRI_xen_pfn Wei Liu
2015-09-03 18:32 ` Tamas K Lengyel
2015-09-03 18:36 ` Razvan Cojocaru
2015-09-04 14:40 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441377644.26292.523.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=rcojocaru@bitdefender.com \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).