xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH for 4.6 v3 2/5] libxc: migration v2 prefix Memory -> Frames
Date: Sun, 6 Sep 2015 21:05:36 +0100	[thread overview]
Message-ID: <1441569939-23562-3-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1441569939-23562-1-git-send-email-wei.liu2@citrix.com>

The prefix "Memory" is confusing because the numbers shown after that
are referring to frames.

Change a bunch of prefixes from "Memory" to "Frames". Also rename
send_memory_verify to verify_frames.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
v3:
1. Change all relevant instances of "Memory".
2. Rename function.
---
 tools/libxc/xc_sr_save.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
index 58667af..7dc3a48 100644
--- a/tools/libxc/xc_sr_save.c
+++ b/tools/libxc/xc_sr_save.c
@@ -451,7 +451,7 @@ static int update_progress_string(struct xc_sr_context *ctx,
     xc_interface *xch = ctx->xch;
     char *new_str = NULL;
 
-    if ( asprintf(&new_str, "Memory iteration %u of %u",
+    if ( asprintf(&new_str, "Frames iteration %u of %u",
                   iter, ctx->save.max_iterations) == -1 )
     {
         PERROR("Unable to allocate new progress string");
@@ -569,7 +569,7 @@ static int suspend_and_send_dirty(struct xc_sr_context *ctx)
     return rc;
 }
 
-static int send_memory_verify(struct xc_sr_context *ctx)
+static int verify_frames(struct xc_sr_context *ctx)
 {
     xc_interface *xch = ctx->xch;
     xc_shadow_op_stats_t stats = { 0, ctx->save.p2m_size };
@@ -586,7 +586,7 @@ static int send_memory_verify(struct xc_sr_context *ctx)
     if ( rc )
         goto out;
 
-    xc_set_progress_prefix(xch, "Memory verify");
+    xc_set_progress_prefix(xch, "Frames verify");
     rc = send_all_pages(ctx);
     if ( rc )
         goto out;
@@ -629,7 +629,7 @@ static int send_domain_memory_live(struct xc_sr_context *ctx)
 
     if ( ctx->save.debug && !ctx->save.checkpointed )
     {
-        rc = send_memory_verify(ctx);
+        rc = verify_frames(ctx);
         if ( rc )
             goto out;
     }
@@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct xc_sr_context *ctx)
     if ( rc )
         goto err;
 
-    xc_set_progress_prefix(xch, "Memory");
+    xc_set_progress_prefix(xch, "Frames");
 
     rc = send_all_pages(ctx);
     if ( rc )
-- 
2.1.4

  parent reply	other threads:[~2015-09-06 20:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 20:05 [PATCH for 4.6 v3 0/5] Migration v2 fix Wei Liu
2015-09-06 20:05 ` [PATCH for 4.6 v3 1/5] libxc: clearer migration v2 debug message Wei Liu
2015-09-06 20:05 ` Wei Liu [this message]
2015-09-06 20:10   ` [PATCH for 4.6 v3 2/5] libxc: migration v2 prefix Memory -> Frames Wei Liu
2015-09-07  9:07   ` Andrew Cooper
2015-09-06 20:05 ` [PATCH for 4.6 v3 3/5] libxc: fix indentation Wei Liu
2015-09-06 20:05 ` [PATCH for 4.6 v3 4/5] libxc: don't populate same pfn more than once in populate_pfns Wei Liu
2015-09-07  7:18   ` Jan Beulich
2015-09-07  9:36     ` Wei Liu
2015-09-07  9:53       ` Jan Beulich
2015-09-07  9:57         ` Wei Liu
2015-09-07 10:08         ` Juergen Gross
2015-09-07  9:59       ` David Vrabel
2015-09-07 10:07         ` Jan Beulich
2015-09-06 20:05 ` [PATCH for 4.6 v3 5/5] libxc: add assertion to avoid setting same bit more than once Wei Liu
2015-09-07 10:04 ` [PATCH for 4.6 v3 0/5] Migration v2 fix Andrew Cooper
2015-09-07 10:07   ` Wei Liu
2015-09-07 10:10     ` Andrew Cooper
2015-09-07 11:22       ` Wei Liu
2015-09-07 11:12 ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441569939-23562-3-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).