Re: [PATCH OSSTEST v2 3/6] ts-xen-install: Add dom0_mem runvar to control dom0 memory

[Ian Campbell <ian.campbell@citrix.com>]

On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  ts-xen-install | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ts-xen-install b/ts-xen-install
> index 0f53382..17edfb7 100755
> --- a/ts-xen-install
> +++ b/ts-xen-install
> @@ -153,7 +153,8 @@ sub setupboot () {
>  	logm("No Xen console device defined for host");
>      }
>      if (toolstack($ho)->{Dom0MemFixed}) {
> -        $xenhopt .= " dom0_mem=512M,max:512M";
> +        my $mem = $r{'dom0_mem'} // 512;

I think the highest preference should be for $r{"$ho->{Ident}_dom0_mem"}
(which makes it host specific in multi host jobs). I think it is probably
still worth having a global dom0_mem runvar you have here too. So:

        my $mem = $r{"$ho->{Ident}_dom0_mem"} // $r{'dom0_mem'} // 512;

(maybe needs wrapping)

> +        $xenhopt .= " dom0_mem=${mem}M,max:${mem}M";
>      }
>  
>      # If /boot/microcode.cpio is present then ts-host-install has