From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 31/31] xen/arm: ITS: Add pci devices in ThunderX Date: Wed, 9 Sep 2015 16:22:25 +0100 Message-ID: <1441812145.24450.335.camel@citrix.com> References: <1441019208-2764-1-git-send-email-vijay.kilari@gmail.com> <1441019208-2764-32-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441019208-2764-32-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com, julien.grall@citrix.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org Cc: Prasun.Kapoor@caviumnetworks.com, vijaya.kumar@caviumnetworks.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-08-31 at 16:36 +0530, vijay.kilari@gmail.com wrote: > [...] > +#define NUM_DEVIDS 54 > + > +static struct pci_dev_list bdf[NUM_DEVIDS] = FYI you could make this static struct pci_dev_list bdf[] = and use ARRAY_SIZE(bdf) in the loops. That would save you having to manually keep NUM_DEVIDS up to date and avoid any possibility of miscounting.