From: Wei Liu <wei.liu2@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path
Date: Wed, 9 Sep 2015 18:03:36 +0100 [thread overview]
Message-ID: <1441818218-5414-2-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com>
... otherwise we have something like:
xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/libxl/libxl_create.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 5128160..29c2641 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -865,6 +865,7 @@ static void initiate_domain_create(libxl__egc *egc,
*/
if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
d_config->b_info.num_vnuma_nodes) {
+ ret = ERROR_INVAL;
LOG(ERROR, "PV vNUMA is not yet supported");
goto error_out;
}
--
2.1.4
next prev parent reply other threads:[~2015-09-09 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 17:03 [PATCH for 4.6 v2 0/3] More vNUMA patches Wei Liu
2015-09-09 17:03 ` Wei Liu [this message]
2015-09-10 10:55 ` [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path Ian Campbell
2015-09-10 15:16 ` Ian Campbell
2015-09-11 13:26 ` Ian Jackson
2015-09-11 13:28 ` Wei Liu
2015-09-11 14:41 ` Ian Jackson
2015-09-09 17:03 ` [PATCH for 4.6 v2 2/3] libxc: introduce xc_domain_getvnuma Wei Liu
2015-09-10 11:01 ` Ian Campbell
2015-09-09 17:03 ` [PATCH for 4.6 v2 3/3] xl/libxl: disallow saving a guest with vNUMA configured Wei Liu
2015-09-09 17:17 ` Boris Ostrovsky
2015-09-09 17:29 ` Wei Liu
2015-09-09 17:33 ` Boris Ostrovsky
2015-09-09 17:41 ` Wei Liu
2015-09-10 13:53 ` Wei Liu
2015-09-09 18:49 ` Andrew Cooper
2015-09-09 20:21 ` Wei Liu
2015-09-10 11:04 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441818218-5414-2-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).