From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH for 4.6 v2 1/3] libxl: set ret to non-zero value in failure path Date: Wed, 9 Sep 2015 18:03:36 +0100 Message-ID: <1441818218-5414-2-git-send-email-wei.liu2@citrix.com> References: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZZin0-0000wf-H9 for xen-devel@lists.xenproject.org; Wed, 09 Sep 2015 17:04:06 +0000 In-Reply-To: <1441818218-5414-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org ... otherwise we have something like: xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed. Signed-off-by: Wei Liu --- tools/libxl/libxl_create.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index 5128160..29c2641 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -865,6 +865,7 @@ static void initiate_domain_create(libxl__egc *egc, */ if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV && d_config->b_info.num_vnuma_nodes) { + ret = ERROR_INVAL; LOG(ERROR, "PV vNUMA is not yet supported"); goto error_out; } -- 2.1.4