From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Brand Subject: [PATCH v3 1/2] xen: arm re-order assignments in mfn_to_xen_entry() Date: Thu, 10 Sep 2015 11:56:28 -0700 Message-ID: <1441911389-3626-2-git-send-email-chris.brand@broadcom.com> References: <1441911389-3626-1-git-send-email-chris.brand@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441911389-3626-1-git-send-email-chris.brand@broadcom.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Julien Grall , Stefano Stabellini , Ian Campbell List-Id: xen-devel@lists.xenproject.org Shuffle lines around so that the assignments in mfn_to_xen_entry() occur in the same order as the bits are declared in lpae_pt_t. This makes it easier to see which ones are never given a value. No change in behaviour. Also fix a minor comment typo. Signed-off-by: Chris Brand Reviewed-by: Julien Grall Acked-by: Ian Campbell --- xen/include/asm-arm/page.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index 5ecfd0705e07..01628f3e96cb 100644 --- a/xen/include/asm-arm/page.h +++ b/xen/include/asm-arm/page.h @@ -197,18 +197,18 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) paddr_t pa = ((paddr_t) mfn) << PAGE_SHIFT; lpae_t e = (lpae_t) { .pt = { - .xn = 1, /* No need to execute outside .text */ - .ng = 1, /* Makes TLB flushes easier */ - .af = 1, /* No need for access tracking */ + .valid = 1, /* Mappings are present */ + .table = 0, /* Set to 1 for links and 4k maps */ + .ai = attr, .ns = 1, /* Hyp mode is in the non-secure world */ .user = 1, /* See below */ - .ai = attr, - .table = 0, /* Set to 1 for links and 4k maps */ - .valid = 1, /* Mappings are present */ + .af = 1, /* No need for access tracking */ + .ng = 1, /* Makes TLB flushes easier */ + .xn = 1, /* No need to execute outside .text */ }};; /* Setting the User bit is strange, but the ATS1H[RW] instructions * don't seem to work otherwise, and since we never run on Xen - * pagetables un User mode it's OK. If this changes, remember + * pagetables in User mode it's OK. If this changes, remember * to update the hard-coded values in head.S too */ switch ( attr ) -- 1.9.1