From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Brand Subject: [PATCH v3 2/2] xen: arm: Be explicit about bit values in mfn_to_xen_entry() Date: Thu, 10 Sep 2015 11:56:29 -0700 Message-ID: <1441911389-3626-3-git-send-email-chris.brand@broadcom.com> References: <1441911389-3626-1-git-send-email-chris.brand@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441911389-3626-1-git-send-email-chris.brand@broadcom.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Julien Grall , Stefano Stabellini , Ian Campbell List-Id: xen-devel@lists.xenproject.org Ensure that every relevant bit is given an explicit value. This has no effect on the generated code, but makes it a little easier to follow. Reported-by: Julien Grall Signed-off-by: Chris Brand --- v3 trims down the list of bits given explicit values v2 adds comments on pxn and avail xen/include/asm-arm/page.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index 01628f3e96cb..a94e978a9995 100644 --- a/xen/include/asm-arm/page.h +++ b/xen/include/asm-arm/page.h @@ -202,9 +202,12 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) .ai = attr, .ns = 1, /* Hyp mode is in the non-secure world */ .user = 1, /* See below */ + .ro = 0, /* Assume read-write */ .af = 1, /* No need for access tracking */ .ng = 1, /* Makes TLB flushes easier */ + .contig = 0, /* Assume non-contiguous */ .xn = 1, /* No need to execute outside .text */ + .avail = 0, /* Reference count for domheap mapping */ }};; /* Setting the User bit is strange, but the ATS1H[RW] instructions * don't seem to work otherwise, and since we never run on Xen -- 1.9.1