From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTest Nested v12 09/21] Wrapper and use
 core_dump_setup() for nested host and normal host to setup coredump sysctl
Date: Fri, 11 Sep 2015 09:43:49 +0100
Message-ID: <1441961029.3549.7.camel@citrix.com>
References: <1440774490-16725-1-git-send-email-robert.hu@intel.com>
	<1440774490-16725-10-git-send-email-robert.hu@intel.com>
	<22001.48267.819147.220179@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22001.48267.819147.220179@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Robert Ho <robert.hu@intel.com>
Cc: "longtao.pang" <longtaox.pang@intel.com>, gordon.jin@intel.com, wei.liu2@citrix.com, di.zheng@intel.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-09-10 at 18:23 +0100, Ian Jackson wrote:
> Robert Ho writes ("[OSSTest Nested v12 09/21] Wrapper and use
> core_dump_setup() for nested host and normal host to setup coredump
> sysctl"):
> > This patch does these 4 things:
> > 1. wrapper coredump setup code from original ts-host-install into
> > TestSupport.pm
> > 2. replace ts-host-install original code with this wrapper function
> 
> You mean
>    break coredump setup code into new function `core_dump_setup'
> 
> Please break this part (the refactoring - ie points 1,2) out into its
> own patch.  You can then say `no functional change' (assuming that's
> true).
> 
> > 3. in debian-hvm-install, create '/var/core' in hvm host post
> > installation.
> > 4. in ts-nested-setup, call this function for l1 host.
> 
> Is there some reason why the mkdir isn't done in core_dump_setup ?

It is, so it's unclear why it is also done in debian-hvm-install, I suspect
that is left over from a previous version of the series which didn't do the
refactoring. Probably it can just be dropped.

> Also it should do `mkdir -p' in case the directory already exists
> somehow.

This is what the code which is refactored into core_dump_setup does
already.

Ian.