From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST] cri-common: Refactor select_prevxenbranch to cri-getprevxenbranch
Date: Fri, 11 Sep 2015 11:06:59 +0100 [thread overview]
Message-ID: <1441966019-19525-1-git-send-email-ian.campbell@citrix.com> (raw)
This moves it outside any prevailing set -x and reduces the amount of
noise in various logs.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
cri-common | 16 +---------------
cri-getprevxenbranch | 19 +++++++++++++++++++
2 files changed, 20 insertions(+), 15 deletions(-)
create mode 100755 cri-getprevxenbranch
diff --git a/cri-common b/cri-common
index 94696ab..2669485 100644
--- a/cri-common
+++ b/cri-common
@@ -61,21 +61,7 @@ repo_tree_rev_fetch_git () {
}
select_prevxenbranch () {
- local b
- local p
- for b in $(./mg-list-all-branches) ; do # already sorted by version
- case "$b" in
- xen*)
- if [ "x$b" = "x$xenbranch" ] ; then
- break
- else
- p=$b
- fi
- ;;
- *) ;;
- esac
- done
- prevxenbranch=$p
+ prevxenbranch=`./cri-getprevxenbranch $xenbranch`
}
select_xenbranch () {
diff --git a/cri-getprevxenbranch b/cri-getprevxenbranch
new file mode 100755
index 0000000..dce52c2
--- /dev/null
+++ b/cri-getprevxenbranch
@@ -0,0 +1,19 @@
+#!/bin/bash
+
+xenbranch=$1
+p=
+
+for b in $(./mg-list-all-branches) ; do # already sorted by version
+ case "$b" in
+ xen*)
+ if [ "x$b" = "x$xenbranch" ] ; then
+ break
+ else
+ p=$b
+ fi
+ ;;
+ *) ;;
+ esac
+done
+
+echo $p
--
2.5.1
next reply other threads:[~2015-09-11 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 10:06 Ian Campbell [this message]
2015-09-11 14:38 ` [PATCH OSSTEST] cri-common: Refactor select_prevxenbranch to cri-getprevxenbranch Ian Jackson
2015-09-11 14:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441966019-19525-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).