From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
wei.liu2@citrix.com
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH 1/5] libxc: remove allocate member from struct xc_dom_image
Date: Fri, 11 Sep 2015 14:32:18 +0200 [thread overview]
Message-ID: <1441974742-27352-2-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1441974742-27352-1-git-send-email-jgross@suse.com>
The allocate() callback in struct xc_dom_image is never set. Remove it.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libxc/include/xc_dom.h | 2 --
tools/libxc/xc_dom_core.c | 4 ----
2 files changed, 6 deletions(-)
diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
index 600aef6..a4ca8a4 100644
--- a/tools/libxc/include/xc_dom.h
+++ b/tools/libxc/include/xc_dom.h
@@ -177,8 +177,6 @@ struct xc_dom_image {
/* kernel loader */
struct xc_dom_arch *arch_hooks;
- /* allocate up to virt_alloc_end */
- int (*allocate) (struct xc_dom_image * dom, xen_vaddr_t up_to);
};
/* --- pluggable kernel loader ------------------------------------- */
diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
index 8466677..b432762 100644
--- a/tools/libxc/xc_dom_core.c
+++ b/tools/libxc/xc_dom_core.c
@@ -579,8 +579,6 @@ int xc_dom_alloc_segment(struct xc_dom_image *dom,
seg->vend = start + pages * page_size;
dom->virt_alloc_end = seg->vend;
- if (dom->allocate)
- dom->allocate(dom, dom->virt_alloc_end);
DOMPRINTF("%-20s: %-12s : 0x%" PRIx64 " -> 0x%" PRIx64
" (pfn 0x%" PRIpfn " + 0x%" PRIpfn " pages)",
@@ -603,8 +601,6 @@ int xc_dom_alloc_page(struct xc_dom_image *dom, char *name)
start = dom->virt_alloc_end;
dom->virt_alloc_end += page_size;
- if (dom->allocate)
- dom->allocate(dom, dom->virt_alloc_end);
pfn = (start - dom->parms.virt_base) / page_size;
DOMPRINTF("%-20s: %-12s : 0x%" PRIx64 " (pfn 0x%" PRIpfn ")",
--
2.1.4
next prev parent reply other threads:[~2015-09-11 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 12:32 [PATCH 0/5] libxc: support building large pv-domains Juergen Gross
2015-09-11 12:32 ` Juergen Gross [this message]
2015-09-11 12:44 ` [PATCH 1/5] libxc: remove allocate member from struct xc_dom_image Ian Jackson
2015-09-25 15:39 ` Ian Campbell
2015-09-28 3:55 ` Juergen Gross
2015-09-28 9:33 ` Ian Campbell
2015-09-11 12:32 ` [PATCH 2/5] libxc: do initrd processing of domain builder in own function Juergen Gross
2015-09-11 12:45 ` Ian Jackson
2015-09-25 15:39 ` Ian Campbell
2015-09-11 12:32 ` [PATCH 3/5] libxc: create unmapped initrd in domain builder if supported Juergen Gross
2015-09-11 12:54 ` Ian Jackson
2015-09-11 13:15 ` Julien Grall
2015-09-11 13:39 ` Juergen Gross
2015-09-25 15:22 ` Ian Campbell
2015-09-11 13:32 ` Juergen Gross
2015-09-11 15:51 ` Ian Jackson
2015-09-11 12:32 ` [PATCH 4/5] libxc: split p2m allocation in domain builder from other magic pages Juergen Gross
2015-10-01 12:47 ` Ian Campbell
2015-10-02 3:55 ` Juergen Gross
2015-10-02 9:04 ` Ian Campbell
2015-10-02 9:14 ` Juergen Gross
2015-10-02 9:28 ` Ian Campbell
2015-09-11 12:32 ` [PATCH 5/5] libxc: create p2m list outside of kernel mapping if supported Juergen Gross
2015-09-11 13:28 ` [PATCH 0/5] libxc: support building large pv-domains Ian Campbell
2015-09-11 13:42 ` Juergen Gross
2015-09-11 13:53 ` Ian Campbell
2015-09-11 14:01 ` Juergen Gross
2015-09-25 15:40 ` Ian Campbell
2015-09-22 12:12 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441974742-27352-2-git-send-email-jgross@suse.com \
--to=jgross@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).