From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: andrew.cooper3@citrix.com, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for 4.6 v4 2/3] xl/libxl: disallow saving a guest with vNUMA configured
Date: Fri, 11 Sep 2015 15:00:35 +0100 [thread overview]
Message-ID: <1441980035.3549.41.camel@citrix.com> (raw)
In-Reply-To: <1441979409-3064-3-git-send-email-wei.liu2@citrix.com>
On Fri, 2015-09-11 at 14:50 +0100, Wei Liu wrote:
> + /* Disallow saving a guest with vNUMA configured because migration
> + * stream does not preserve node information.
> + *
> + * Do not differentiate "no vnuma configuration" from "empty vnuma
> + * configuration".
> + */
> + rc = xc_domain_getvnuma(CTX->xch, domid, &nr_vnodes, &nr_vmemranges,
> + &nr_vcpus, NULL, NULL, NULL);
> + if (rc != -1 || errno == XEN_ENOBUFS) {
This is not as we discussed, it is neither what I proposed nor what you
(incorrectly IMHO) corrected it to be in the previous thread.
Ian
next prev parent reply other threads:[~2015-09-11 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 13:50 [PATCH for 4.6 v4 0/3] More vNUMA patches Wei Liu
2015-09-11 13:50 ` [PATCH for 4.6 v4 1/3] libxc: introduce xc_domain_getvnuma Wei Liu
2015-09-11 13:53 ` Wei Liu
2015-09-11 13:50 ` [PATCH for 4.6 v4 2/3] xl/libxl: disallow saving a guest with vNUMA configured Wei Liu
2015-09-11 14:00 ` Ian Campbell [this message]
2015-09-11 14:14 ` Wei Liu
2015-09-11 14:24 ` Ian Campbell
2015-09-11 14:31 ` Wei Liu
2015-09-11 15:05 ` Ian Campbell
2015-09-11 15:09 ` Wei Liu
2015-09-11 15:53 ` Ian Campbell
2015-09-11 15:56 ` Wei Liu
2015-09-11 13:50 ` [PATCH for 4.6 v4 3/3] xl: handle empty vnuma configuration Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441980035.3549.41.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).