From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6 v4 2/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Fri, 11 Sep 2015 15:00:35 +0100 Message-ID: <1441980035.3549.41.camel@citrix.com> References: <1441979409-3064-1-git-send-email-wei.liu2@citrix.com> <1441979409-3064-3-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZaOsZ-0002Xw-K1 for xen-devel@lists.xenproject.org; Fri, 11 Sep 2015 14:00:39 +0000 In-Reply-To: <1441979409-3064-3-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: andrew.cooper3@citrix.com, Ian Jackson List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-11 at 14:50 +0100, Wei Liu wrote: > + /* Disallow saving a guest with vNUMA configured because migration > + * stream does not preserve node information. > + * > + * Do not differentiate "no vnuma configuration" from "empty vnuma > + * configuration". > + */ > + rc = xc_domain_getvnuma(CTX->xch, domid, &nr_vnodes, &nr_vmemranges, > + &nr_vcpus, NULL, NULL, NULL); > + if (rc != -1 || errno == XEN_ENOBUFS) { This is not as we discussed, it is neither what I proposed nor what you (incorrectly IMHO) corrected it to be in the previous thread. Ian