xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Jim Fehlig <jfehlig@suse.com>,
	Yang Hongyang <yanghy@cn.fujitsu.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on migration fd and reinstate afterwards
Date: Fri, 11 Sep 2015 15:11:32 +0100	[thread overview]
Message-ID: <1441980692.3549.49.camel@citrix.com> (raw)
In-Reply-To: <20150911125605.GI1695@zion.uk.xensource.com>

On Fri, 2015-09-11 at 13:56 +0100, Wei Liu wrote:
> On Fri, Sep 11, 2015 at 11:50:14AM +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY
> > on migration fd and reinstate afterwards"):
> > > The fd passed to us by libvirt for both save and restore has at least
> > > O_NONBLOCK set, which libxl does not expect and therefore fails to
> > > handle any EAGAIN which might arise.
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > > For 4.6: This fixes migration with libvirt, which I think is worth
> > > doing before the release.
> > 
> > Indeed.
> > 
> 
> +1
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Pushed to staging and staging-4.6, thanks.

  reply	other threads:[~2015-09-11 14:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 10:42 [PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on migration fd and reinstate afterwards Ian Campbell
2015-09-11 10:50 ` Ian Jackson
2015-09-11 12:56   ` Wei Liu
2015-09-11 14:11     ` Ian Campbell [this message]
2015-09-11 13:44 ` Andrew Cooper
2015-09-11 14:13   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441980692.3549.49.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).