From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY on
 migration fd and reinstate afterwards
Date: Fri, 11 Sep 2015 15:11:32 +0100
Message-ID: <1441980692.3549.49.camel@citrix.com>
References: <1441968171-15844-1-git-send-email-ian.campbell@citrix.com>
	<22002.45542.20329.665860@mariner.uk.xensource.com>
	<20150911125605.GI1695@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150911125605.GI1695@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Shriram Rajagopalan <rshriram@cs.ubc.ca>, Andrew Cooper <andrew.cooper3@citrix.com>, Jim Fehlig <jfehlig@suse.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-09-11 at 13:56 +0100, Wei Liu wrote:
> On Fri, Sep 11, 2015 at 11:50:14AM +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH for-4.6] libxl: clear O_NONBLOCK|O_NDELAY
> > on migration fd and reinstate afterwards"):
> > > The fd passed to us by libvirt for both save and restore has at least
> > > O_NONBLOCK set, which libxl does not expect and therefore fails to
> > > handle any EAGAIN which might arise.
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > > For 4.6: This fixes migration with libvirt, which I think is worth
> > > doing before the release.
> > 
> > Indeed.
> > 
> 
> +1
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Pushed to staging and staging-4.6, thanks.