From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6 v4 2/3] xl/libxl: disallow saving a guest with vNUMA configured Date: Fri, 11 Sep 2015 16:53:57 +0100 Message-ID: <1441986837.3549.93.camel@citrix.com> References: <1441979409-3064-1-git-send-email-wei.liu2@citrix.com> <1441979409-3064-3-git-send-email-wei.liu2@citrix.com> <1441980035.3549.41.camel@citrix.com> <20150911141415.GN1695@zion.uk.xensource.com> <1441981461.3549.54.camel@citrix.com> <20150911143149.GO1695@zion.uk.xensource.com> <1441983913.3549.79.camel@citrix.com> <20150911150934.GR1695@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZaQeH-0005o0-IJ for xen-devel@lists.xenproject.org; Fri, 11 Sep 2015 15:54:02 +0000 In-Reply-To: <20150911150934.GR1695@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-11 at 16:09 +0100, Wei Liu wrote: > > > Note that virtual NUMA for PV guest is not yet supported, because > > > there is an issue with cpuid handling that affects PV virtual NUMA. > > > +Further more, guest with virtual NUMA cannot be saved or migrated > > > > I _think_ (but am not 100% sure) that in the sense you mean it is > > "Furthermore". I don't think "Further more," actually means anything. > > > > I can fix as I commit. > > > > Yes please. I went with: +Furthermore, guests with virtual NUMA cannot be saved or migrated +because the migration stream does not preserve node information. I've applied all three patches in this series to staging and 4.6. The conflict you mentioned elsewhere (patch #1) was just the presence of xc_domain_soft_reset in staging but not staging-4.6. I resolved it, I don't think I can have gotten it wrong, but do check ;-) Ian.