xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Liu Jinsong <jinsong.liu@alibaba-inc.com>,
	Christoph Egger <chegger@amazon.de>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>
Subject: [PATCH 0/4] Fix tools/xen-mceinj to handle >=4GB guest memory
Date: Tue, 15 Sep 2015 16:29:36 +0800	[thread overview]
Message-ID: <1442305780-12790-1-git-send-email-haozhong.zhang@intel.com> (raw)

The existing xen-mceinj can not inject MCE through MSR_MCI_ADDR to a
domain w/ more than 4GB memory, e.g. if domain 0 has more than 4GB
memory, the execution of the command
        xen-mceinj -d 0 -t 0 -p 0x2721a900
will fail w/ a message "Failed to get pfn list ffffffff: Operation not
supported".

The cause is that the hypercall XEN_DOMCTL_getmemlist used by
xen-mceinj to translate the guest physical address (argument of '-p')
to the host machine address always fails if the domain has more than
4GB memory due to the mitigation of XSA-74.

This patchset fixes this problem by moving the translation from
xen-mceinj to the hypervisor, so that it is not necessary to use
XEN_DOMCTL_getmemlist.

The first two patches just fix serval code-style issues, while the
other two are the actual fix.

Haozhong Zhang (4):
  x86/mce: Fix code style
  tools/mceinject: Fix code style
  x86/mce: Translate passed-in GPA to host machine address
  tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR

 tools/tests/mce-test/tools/xen-mceinj.c | 141 +++++---------------------------
 xen/arch/x86/cpu/mcheck/mce.c           |  43 ++++++++--
 xen/include/public/arch-x86/xen-mca.h   |  31 +++----
 3 files changed, 77 insertions(+), 138 deletions(-)

--
2.4.8

             reply	other threads:[~2015-09-15  8:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  8:29 Haozhong Zhang [this message]
2015-09-15  8:29 ` [PATCH 1/4] x86/mce: Fix code style Haozhong Zhang
2015-09-15  8:47   ` Egger, Christoph
2015-09-15 13:13   ` Jan Beulich
2015-09-15 13:19     ` Haozhong Zhang
2015-09-15  8:29 ` [PATCH 2/4] tools/mceinject: " Haozhong Zhang
2015-09-15  8:48   ` Egger, Christoph
2015-09-15 10:15     ` Ian Campbell
2015-09-15 13:11   ` Wei Liu
2015-09-15  8:29 ` [PATCH 3/4] x86/mce: Translate passed-in GPA to host machine address Haozhong Zhang
2015-09-15  9:14   ` Egger, Christoph
2015-09-15  9:48     ` Haozhong Zhang
2015-09-15 13:24   ` Jan Beulich
2015-09-15 13:42     ` Haozhong Zhang
2015-09-15 13:47       ` Jan Beulich
2015-09-15 13:51         ` Haozhong Zhang
2015-09-15 13:50       ` Andrew Cooper
2015-09-16  0:38         ` Haozhong Zhang
2015-09-15  8:29 ` [PATCH 4/4] tools/xen-mceinj: Pass in GPA when injecting through MSR_MCI_ADDR Haozhong Zhang
2015-09-15 10:02   ` Wei Liu
2015-09-15 10:08     ` Egger, Christoph
2015-09-15 10:16       ` Wei Liu
2015-09-15 10:17   ` Egger, Christoph
2015-09-15 10:28     ` Haozhong Zhang
2015-09-15 10:34       ` Egger, Christoph
2015-09-15 10:20   ` Ian Campbell
2015-09-15 10:38     ` Haozhong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442305780-12790-1-git-send-email-haozhong.zhang@intel.com \
    --to=haozhong.zhang@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chegger@amazon.de \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jinsong.liu@alibaba-inc.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).