xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei.Liu2@citrix.com, stefano.stabellini@citrix.com
Subject: Re: [PATCH for-4.6] xen/arm: vgic-v2: Map the GIC virtual CPU interface with the correct size
Date: Fri, 18 Sep 2015 09:53:30 +0100	[thread overview]
Message-ID: <1442566410.18856.252.camel@citrix.com> (raw)
In-Reply-To: <1442512803-798-1-git-send-email-julien.grall@citrix.com>

On Thu, 2015-09-17 at 19:00 +0100, Julien Grall wrote:
> On GICv2, the GIC virtual CPU interface is at minimum 8KB. Due some to
> some necessary quirk for GIC using 64KB stride, we are mapping the
> region in 2 time.
> The first mapping is 4KB and the second one is 8KB, i.e 12KB in total.
> Although the minimum supported size (and widely used) is 8KB. This means
> that we are mapping 4KB more to any guest using GICv2.
> 
> While this looks scary at first glance, the GIC virtual CPU interface is
> most frequently at the end the GIC I/O region. So we will most likely
> map an an unused I/O region or a mirrored version of GICV for platform
> using 64KB stride.
> 
> Nonetheless, fix the second mapping to only map 4KB.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
> 
> This is a candidate for Xen 4.6 and backport to Xen 4.5.

I concur and with Wei not being around I shall plan to apply later today
unless there are objections.

  reply	other threads:[~2015-09-18  8:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 18:00 [PATCH for-4.6] xen/arm: vgic-v2: Map the GIC virtual CPU interface with the correct size Julien Grall
2015-09-18  8:53 ` Ian Campbell [this message]
2015-09-21 11:54   ` Ian Campbell
2015-09-21 12:28     ` Julien Grall
2015-09-21 12:56       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442566410.18856.252.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Wei.Liu2@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).