From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 20/26] ts-debian-hvm-install: Set $gsuite after $gho Date: Mon, 21 Sep 2015 10:29:33 +0100 Message-ID: <1442827773.10338.22.camel@citrix.com> References: <1442598616-2884-1-git-send-email-ian.jackson@eu.citrix.com> <1442598616-2884-7-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZdxPl-0004hF-GA for xen-devel@lists.xenproject.org; Mon, 21 Sep 2015 09:29:37 +0000 In-Reply-To: <1442598616-2884-7-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-18 at 18:50 +0100, Ian Jackson wrote: > $gsuite was set from guest_var, but before $gho was set, leading to an > undefined value warning from Perl. > > This would ignore any guest-specific suite runvars. AFAICT these are > set by some of the jobs in make-distros-flight. I think the effect of > this change is to apply workarounds for the intended suite, rather > than for wheezy. > > (Although there is another assignment to $gho later in > ts-debian-hvm-install, for stage 2, the stage 2 code does some trivial > TestSupport calls and does not need $gsuite. So there is no need to > make arrangements to assign to $gsuite - or, for that matter, $kernel > or $ramdisk, in that path.) > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell