xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 22/28] ts-debian-hvm-install: Do not create EFI partition if EFI not in use
Date: Tue, 22 Sep 2015 16:12:43 +0100	[thread overview]
Message-ID: <1442934764-8672-7-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1442934764-8672-1-git-send-email-ian.jackson@eu.citrix.com>

If we are booting our install ISO using a non-EFI executable, don't
try to provide an EFI for the installed system either.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
v4: Fix regexp to match efi.img (!)
    Rebased, fixed code motion conflict.
---
 ts-debian-hvm-install |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
index b9f9025..6646a5a 100755
--- a/ts-debian-hvm-install
+++ b/ts-debian-hvm-install
@@ -49,6 +49,7 @@ our $guesthost= "$gn.guest.osstest";
 our $gho;
 
 our ($kernel, $ramdisk);
+our $bootfile;
 
 our $gsuite;
 
@@ -56,7 +57,7 @@ sub preseed () {
 
     my $preseed_file = preseed_base($gho,$gsuite,'','',());
 
-    $preseed_file .= (<<END);
+    $preseed_file .= (<<END.($bootfile =~ m/\befi\b/ ? <<END : '').<<END);
 d-i netcfg/get_hostname string $gn
 
 d-i partman-auto/disk string /dev/xvda
@@ -64,12 +65,14 @@ d-i partman-auto/method string  regular
 
 d-i partman-auto/expert_recipe string \\
         boot-root :: \\
+END
                 512 50 512 vfat \\
                         \$primary{ } \$bootable{ } \\
                         method{ efi } format{ } \\
                         use_filesystem{ } filesystem{ vfat } \\
                         mountpoint{ /boot/efi } \\
                 . \\
+END
                 5000 50 5000 ext4 \\
                         method{ format } format{ } \\
                         use_filesystem{ } filesystem{ ext4 } \\
@@ -222,7 +225,7 @@ sub prep () {
         my $cmds = iso_copy_content_from_image($gho, $newiso);
         target_cmd_root($ho, $cmds, $isotimeout);
 
-        my $bootfile = 'boot/grub/efi.img';
+        $bootfile = 'boot/grub/efi.img';
         if (!target_file_exists($ho, "$newiso/$bootfile")) {
             $bootfile = "isolinux/isolinux.bin";
             push @isogen_extra, qw(-c isolinux/boot.cat);
-- 
1.7.10.4

  parent reply	other threads:[~2015-09-22 15:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 15:12 [OSSTEST PATCH v4 00/28] xen.git#staging smoke tests Ian Jackson
2015-09-22 15:12 ` [OSSTEST PATCH 05/28] sg-report-flight: Better searching for used revisions Ian Jackson
2015-09-22 15:24   ` Ian Campbell
2015-09-22 15:12 ` [OSSTEST PATCH 14/28] Provide xen-unstable-smoke branch Ian Jackson
2015-09-22 15:29   ` Ian Campbell
2015-09-22 15:31     ` Ian Jackson
2015-09-22 15:12 ` [OSSTEST PATCH 15/28] cr-daily-branch: Use mg-adjust-flight to have smoke tests reuse builds Ian Jackson
2015-09-22 15:30   ` Ian Campbell
2015-09-22 15:32     ` Ian Jackson
2015-09-22 15:12 ` [OSSTEST PATCH 19/28] ts-debian-hvm-install: Defer preseed generation Ian Jackson
2015-09-22 15:31   ` Ian Campbell
2015-09-22 15:12 ` [OSSTEST PATCH 20/28] ts-debian-hvm-install: Cope with images containing only isolinux Ian Jackson
2015-09-22 15:32   ` Ian Campbell
2015-09-22 15:12 ` Ian Jackson [this message]
2015-09-22 15:32   ` [OSSTEST PATCH 22/28] ts-debian-hvm-install: Do not create EFI partition if EFI not in use Ian Campbell
2015-09-22 15:12 ` [OSSTEST PATCH 28/28] Executive: Delay releasing build host shares by 90s Ian Jackson
2015-09-22 15:34   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442934764-8672-7-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).