From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 05/28] sg-report-flight: Better searching for used revisions Date: Tue, 22 Sep 2015 16:24:53 +0100 Message-ID: <1442935493.10338.176.camel@citrix.com> References: <1442934764-8672-1-git-send-email-ian.jackson@eu.citrix.com> <1442934764-8672-2-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZePRC-0005Fj-5a for xen-devel@lists.xenproject.org; Tue, 22 Sep 2015 15:24:58 +0000 In-Reply-To: <1442934764-8672-2-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-22 at 16:12 +0100, Ian Jackson wrote: > The old algorithm used for determining which flight might be a > suitable test of a particular revision was rather crude, in two ways: > > * It would look at _all_ jobs in a flight referred to from the flight > of interest, not just at the relevant jobs; > > * It would only look at the direct referents of the flight in > question. So for example, if a flight of interest contained > test-amd64-i386-libvirt, it would find a referenced > build-i386-libvirt in another flight, but that build refers to > build-i386, and it would not look at that (unless it happened to be > in the same flight). > > Fix this by redoing the revision archaeology, with some $why tracking > to explain how we found a particular revision. > > cs-bisection-step and sg-check-tested arguably ought to do do it this > way too. But I am leaving centralising this new logic, and using it > in those other programs, for another day. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell