From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST] make_qcow2: Look for qemu-img under /usr as well as /usr/local
Date: Tue, 22 Sep 2015 16:58:26 +0100 [thread overview]
Message-ID: <1442937506.10338.188.camel@citrix.com> (raw)
In-Reply-To: <22017.30403.151751.636356@mariner.uk.xensource.com>
On Tue, 2015-09-22 at 16:41 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] make_qcow2: Look for qemu-img under
> /usr as well as /usr/local"):
> > Older Xen's installed in /usr by default, so we need to check where
> > qemu-img if we want these tests to work on those versions.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> But, why are we executing a utility from /usr/lib/xen/bin ? If this
> utility is useful to osstest it is presumably useful to users too, and
> in that case it should be on PATH (under some suitable name).
We install qemu-upstream under our own prefix, I think to avoid conficting
with the users own qemu installations?
qemu-img comes from there. We do install qemu-xen-img (from trad) into
$PATH, but when I wrote this test I thought it preferable to use qemu-img.
Ian.
next prev parent reply other threads:[~2015-09-22 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 15:34 [PATCH OSSTEST] make_qcow2: Look for qemu-img under /usr as well as /usr/local Ian Campbell
2015-09-22 15:41 ` Ian Jackson
2015-09-22 15:58 ` Ian Campbell [this message]
2015-09-22 16:06 ` Ian Jackson
2015-09-22 21:36 ` Stefano Stabellini
2015-09-23 8:25 ` Ian Campbell
2015-09-23 18:18 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442937506.10338.188.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).