From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 for-4.6 1/2] libxl: fix devd removal path Date: Wed, 23 Sep 2015 12:08:42 +0100 Message-ID: <1443006522.10338.228.camel@citrix.com> References: <1443002816-95720-1-git-send-email-roger.pau@citrix.com> <1443002816-95720-2-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zehup-0002Qq-Ae for xen-devel@lists.xenproject.org; Wed, 23 Sep 2015 11:08:47 +0000 In-Reply-To: <1443002816-95720-2-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Alex Velazquez , Wei Liu , Ian Jackson List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE1LTA5LTIzIGF0IDEyOjA2ICswMjAwLCBSb2dlciBQYXUgTW9ubmUgd3JvdGU6 Cj4gVGhlIGN1cnJlbnQgZmxvdyBvZiB0aGUgZGV2ZCBoZWxwZXIgKGluIGNoYXJnZSBvZiBsYXVu Y2hpbmcgaG90cGx1Zwo+IHNjcmlwdHMKPiBpbnNpZGUgb2YgZHJpdmVyIGRvbWFpbnMpIGlzIHRv IHdhaXQgZm9yIHRoZSBkZXZpY2UgYmFja2VuZCB0byBzd2l0Y2ggdG8KPiBzdGF0ZSA2ICAoWGVu YnVzU3RhdGVDbG9zZWQpIGFuZCB0aGVuIHJlbW92ZSBpdC4gVGhpcyBpcyBub3QgY29ycmVjdCwK PiBzaW5jZQo+IGEgZG9tYWluIGNhbiByZWNvbm5lY3QgaXQncyBQViBkZXZpY2VzIGFzIG1hbnkg dGltZXMgYXMgaXQgd2FudHMuCj4gCj4gSW4gb3JkZXIgdG8gZml4IHRoaXMsIGludHJvZHVjZSB0 aGUgZm9sbG93aW5nIGxvZ2ljOiB0aGUgY29udHJvbCBkb21haW4KPiB3aWxsCj4gc2V0IHRoZSAi b25saW5lIiBiYWNrZW5kIG5vZGUgdG8gMCB3aGVuIGl0IHdhbnRzIHRoZSBkcml2ZXIgZG9tYWlu IHRvCj4gZGlzY29ubmVjdCB0aGUgZGV2aWNlLCBzbyBub3cgdGhlIGNvbmRpdGlvbiBhcHBsaWVk IGluIGRldmQgaXMgdGhhdAo+ICJzdGF0ZSIKPiBtdXN0IGJlIDYgYW5kICJvbmxpbmUiIDAgaW4g b3JkZXIgdG8gcHJvY2VlZCB3aXRoIHRoZSBkaXNjb25uZWN0aW9uLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IFJlcG9ydGVkLWJ5 OiBBbGV4IFZlbGF6cXVleiA8YWxleC5qLnZlbGF6cXVlekBnbWFpbC5jb20+Cj4gQ2M6IEFsZXgg VmVsYXpxdWV6IDxhbGV4LmoudmVsYXpxdWV6QGdtYWlsLmNvbT4KPiBDYzogSWFuIEphY2tzb24g PGlhbi5qYWNrc29uQGV1LmNpdHJpeC5jb20+CgpBY2tlZC1ieTogSWFuIENhbXBiZWxsIDxpYW4u Y2FtcGJlbGxAY2l0cml4LmNvbT4KCj4gQ2M6IFdlaSBMaXUgPHdlaS5saXUyQGNpdHJpeC5jb20+ Cj4gLS0tCj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAgLSBVc2Ugc3RycmNociBhbmQgc3RyY21wIGlu IG9yZGVyIHRvIGNoZWNrIHRoZSBldmVudCBwYXRoLgo+ICAtIFJlbW92ZSBzdXBlcmZsdW91cyBM T0cgaW4gY2FzZSBvZiBmYWlsZWQgeGVuc3RvcmUgd3JpdGUuCj4gIC0gUmVtb3ZlIHVuZWVkZWQg c3RybGVuIGNoZWNrcy4KPiAtLS0KPiAgdG9vbHMvbGlieGwvbGlieGwuYyAgICAgICAgfCAzMiAr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICB0b29scy9saWJ4bC9saWJ4bF9kZXZp Y2UuYyB8ICA5ICsrKystLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyks IDE5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90b29scy9saWJ4bC9saWJ4bC5jIGIv dG9vbHMvbGlieGwvbGlieGwuYwo+IGluZGV4IDEwZDE5MDkuLjZjNGVmNmQgMTAwNjQ0Cj4gLS0t IGEvdG9vbHMvbGlieGwvbGlieGwuYwo+ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsLmMKPiBAQCAt NDQxMCwzMiArNDQxMCwzNiBAQCBzdGF0aWMgdm9pZCBiYWNrZW5kX3dhdGNoX2NhbGxiYWNrKGxp YnhsX19lZ2MKPiAqZWdjLCBsaWJ4bF9fZXZfeHN3YXRjaCAqd2F0Y2gsCj4gICAgICBsaWJ4bF9f YW8gKm5lc3RlZF9hbyA9IGxpYnhsX19uZXN0ZWRfYW9fY3JlYXRlKGRkb21haW4tPmFvKTsKPiAg ICAgIFNUQVRFX0FPX0dDKG5lc3RlZF9hbyk7Cj4gICAgICBjaGFyICpwLCAqcGF0aDsKPiAtICAg IGNvbnN0IGNoYXIgKnNzdGF0ZTsKPiAtICAgIGludCBzdGF0ZSwgcmMsIG51bV9kZXZzOwo+ICsg ICAgY29uc3QgY2hhciAqc3N0YXRlLCAqc29ubGluZTsKPiArICAgIGludCBzdGF0ZSwgb25saW5l LCByYywgbnVtX2RldnM7Cj4gICAgICBsaWJ4bF9fZGV2aWNlICpkZXYgPSBOVUxMOwo+ICAgICAg bGlieGxfX2Rkb21haW5fZGV2aWNlICpkZGV2ID0gTlVMTDsKPiAgICAgIGxpYnhsX19kZG9tYWlu X2d1ZXN0ICpkZ3Vlc3QgPSBOVUxMOwo+ICAgICAgYm9vbCBmcmVlX2FvID0gZmFsc2U7Cj4gIAo+ IC0gICAgLyogQ2hlY2sgaWYgZXZlbnRfcGF0aCBlbmRzIHdpdGggInN0YXRlIiBhbmQgdHJ1bmNh dGUgaXQgKi8KPiAtICAgIGlmIChzdHJsZW4oZXZlbnRfcGF0aCkgPCBzdHJsZW4oInN0YXRlIikp Cj4gLSAgICAgICAgZ290byBza2lwOwo+IC0KPiArICAgIC8qIENoZWNrIGlmIGV2ZW50X3BhdGgg ZW5kcyB3aXRoICJzdGF0ZSIgb3IgIm9ubGluZSIgYW5kIHRydW5jYXRlCj4gaXQuICovCj4gICAg ICBwYXRoID0gbGlieGxfX3N0cmR1cChnYywgZXZlbnRfcGF0aCk7Cj4gLSAgICBwID0gcGF0aCAr IHN0cmxlbihwYXRoKSAtIHN0cmxlbigic3RhdGUiKSAtIDE7Cj4gLSAgICBpZiAoKnAgIT0gJy8n KQo+ICsgICAgcCA9IHN0cnJjaHIocGF0aCwgJy8nKTsKPiArICAgIGlmIChwID09IE5VTEwpCj4g ICAgICAgICAgZ290byBza2lwOwo+IC0gICAgKnAgPSAnXDAnOwo+IC0gICAgcCsrOwo+IC0gICAg aWYgKHN0cmNtcChwLCAic3RhdGUiKSAhPSAwKQo+ICsgICAgaWYgKHN0cmNtcChwLCAiL3N0YXRl IikgIT0gMCAmJiBzdHJjbXAocCwgIi9vbmxpbmUiKSAhPSAwKQo+ICAgICAgICAgIGdvdG8gc2tp cDsKPiArICAgIC8qIFRydW5jYXRlIHRoZSBzdHJpbmcgc28gaXQgcG9pbnRzIHRvIHRoZSBiYWNr ZW5kIGRpcmVjdG9yeS4gKi8KPiArICAgICpwID0gJ1wwJzsKPiAgCj4gLSAgICAvKiBDaGVjayBp ZiB0aGUgc3RhdGUgaXMgMSAoWGVuYnVzU3RhdGVJbml0aWFsaXNpbmcpIG9yIGdyZWF0ZXIgKi8K PiAtICAgIHJjID0gbGlieGxfX3hzX3JlYWRfY2hlY2tlZChnYywgWEJUX05VTEwsIGV2ZW50X3Bh dGgsICZzc3RhdGUpOwo+ICsgICAgLyogRmV0Y2ggdGhlIHZhbHVlIG9mIHRoZSBzdGF0ZSBhbmQg b25saW5lIG5vZGVzLiAqLwo+ICsgICAgcmMgPSBsaWJ4bF9feHNfcmVhZF9jaGVja2VkKGdjLCBY QlRfTlVMTCwgR0NTUFJJTlRGKCIlcy9zdGF0ZSIsCj4gcGF0aCksCj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJnNzdGF0ZSk7Cj4gICAgICBpZiAocmMgfHwgIXNzdGF0ZSkKPiAg ICAgICAgICBnb3RvIHNraXA7Cj4gICAgICBzdGF0ZSA9IGF0b2koc3N0YXRlKTsKPiAgCj4gKyAg ICByYyA9IGxpYnhsX194c19yZWFkX2NoZWNrZWQoZ2MsIFhCVF9OVUxMLCBHQ1NQUklOVEYoIiVz L29ubGluZSIsCj4gcGF0aCksCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJnNv bmxpbmUpOwo+ICsgICAgaWYgKHJjIHx8ICFzb25saW5lKQo+ICsgICAgICAgIGdvdG8gc2tpcDsK PiArICAgIG9ubGluZSA9IGF0b2koc29ubGluZSk7Cj4gKwo+ICAgICAgZGV2ID0gbGlieGxfX3ph bGxvYyhOT0dDLCBzaXplb2YoKmRldikpOwo+ICAgICAgcmMgPSBsaWJ4bF9fcGFyc2VfYmFja2Vu ZF9wYXRoKGdjLCBwYXRoLCBkZXYpOwo+ICAgICAgaWYgKHJjKQo+IEBAIC00NDc3LDcgKzQ0ODEs NyBAQCBzdGF0aWMgdm9pZCBiYWNrZW5kX3dhdGNoX2NhbGxiYWNrKGxpYnhsX19lZ2MgKmVnYywK PiBsaWJ4bF9fZXZfeHN3YXRjaCAqd2F0Y2gsCj4gICAgICAgICAgcmMgPSBhZGRfZGV2aWNlKGVn YywgbmVzdGVkX2FvLCBkZ3Vlc3QsIGRkZXYpOwo+ICAgICAgICAgIGlmIChyYyA+IDApCj4gICAg ICAgICAgICAgIGZyZWVfYW8gPSB0cnVlOwo+IC0gICAgfSBlbHNlIGlmIChzdGF0ZSA9PSBYZW5i dXNTdGF0ZUNsb3NlZCkgewo+ICsgICAgfSBlbHNlIGlmIChzdGF0ZSA9PSBYZW5idXNTdGF0ZUNs b3NlZCAmJiBvbmxpbmUgPT0gMCkgewo+ICAgICAgICAgIC8qCj4gICAgICAgICAgICogUmVtb3Zh bCBvZiBhbiBhY3RpdmUgZGV2aWNlLCByZW1vdmUgaXQgZnJvbSB0aGUgbGlzdCBhbmQKPiAgICAg ICAgICAgKiBmcmVlIGl0J3MgZGF0YSBzdHJ1Y3R1cmVzIGlmIHRoZXkgYXJlIG5vIGxvbmdlciBu ZWVkZWQuCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2RldmljZS5jIGIvdG9vbHMv bGlieGwvbGlieGxfZGV2aWNlLmMKPiBpbmRleCBiZWU1ZWQ1Li44NWEzNjYyIDEwMDY0NAo+IC0t LSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2RldmljZS5jCj4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxf ZGV2aWNlLmMKPiBAQCAtODM3LDE2ICs4MzcsMTUgQEAgdm9pZCBsaWJ4bF9faW5pdGlhdGVfZGV2 aWNlX3JlbW92ZShsaWJ4bF9fZWdjICplZ2MsCj4gICAgICAgICAgICAgIGdvdG8gb3V0Owo+ICAg ICAgICAgIH0KPiAgCj4gKyAgICAgICAgcmMgPSBsaWJ4bF9feHNfd3JpdGVfY2hlY2tlZChnYywg dCwgb25saW5lX3BhdGgsICIwIik7Cj4gKyAgICAgICAgaWYgKHJjKQo+ICsgICAgICAgICAgICBn b3RvIG91dDsKPiArCj4gICAgICAgICAgLyoKPiAgICAgICAgICAgKiBDaGVjayBpZiBkZXZpY2Ug aXMgYWxyZWFkeSBpbiAiY2xvc2VkIiBzdGF0ZSwgaW4gd2hpY2ggY2FzZQo+ICAgICAgICAgICAq IGl0IHNob3VsZCBub3QgYmUgY2hhbmdlZC4KPiAgICAgICAgICAgKi8KPiAgICAgICAgICAgaWYg KHN0YXRlICYmIGF0b2koc3RhdGUpICE9IFhlbmJ1c1N0YXRlQ2xvc2VkKSB7Cj4gLSAgICAgICAg ICAgIHJjID0gbGlieGxfX3hzX3dyaXRlX2NoZWNrZWQoZ2MsIHQsIG9ubGluZV9wYXRoLCAiMCIp Owo+IC0gICAgICAgICAgICBpZiAocmMpIHsKPiAtICAgICAgICAgICAgICAgIExPRyhFUlJPUiwg InVuYWJsZSB0byB3cml0ZSB0byB4ZW5zdG9yZSBwYXRoICVzIiwKPiBvbmxpbmVfcGF0aCk7Cj4g LSAgICAgICAgICAgICAgICBnb3RvIG91dDsKPiAtICAgICAgICAgICAgfQo+ICAgICAgICAgICAg ICByYyA9IGxpYnhsX194c193cml0ZV9jaGVja2VkKGdjLCB0LCBzdGF0ZV9wYXRoLAo+IEdDU1BS SU5URigiJWQiLCBYZW5idXNTdGF0ZUNsb3NpbmcpKTsKPiAgICAgICAgICAgICAgaWYgKHJjKSB7 Cj4gICAgICAgICAgICAgICAgICBMT0coRVJST1IsICJ1bmFibGUgdG8gd3JpdGUgdG8geGVuc3Rv cmUgcGF0aCAlcyIsCj4gc3RhdGVfcGF0aCk7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=