From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 3/4] tools: add tools support for Intel CDP Date: Thu, 24 Sep 2015 11:57:47 +0100 Message-ID: <1443092267.10338.273.camel@citrix.com> References: <1442482536-12024-1-git-send-email-he.chen@linux.intel.com> <1442482536-12024-4-git-send-email-he.chen@linux.intel.com> <55FA980C.6040401@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zf4GT-0000P0-MG for xen-devel@lists.xenproject.org; Thu, 24 Sep 2015 11:00:37 +0000 In-Reply-To: <55FA980C.6040401@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , He Chen , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, chao.p.peng@linux.intel.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-09-17 at 11:38 +0100, Andrew Cooper wrote: > @@ -320,6 +333,8 @@ int xc_psr_cat_get_l3_info(xc_interface *xch, > > uint32_t socket, > > { > > *cos_max = sysctl.u.psr_cat_op.u.l3_info.cos_max; > > *cbm_len = sysctl.u.psr_cat_op.u.l3_info.cbm_len; > > + *cdp_enabled = sysctl.u.psr_cat_op.u.l3_info.flags & > > + XEN_SYSCTL_PSR_CAT_L3_CDP; > > !!(sysctl.u.psr_cat_op.u.l3_info.flags & XEN_SYSCTL_PSR_CAT_L3_CDP); > > To turn it into a proper boolean, rather than a just a non-zero integer. Given that *cdp_endabled is bool type does this not happen automagically?