From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v4 3/4] tools: add tools support for Intel CDP Date: Thu, 24 Sep 2015 12:00:50 +0100 Message-ID: <1443092450.10338.276.camel@citrix.com> References: <1442482536-12024-1-git-send-email-he.chen@linux.intel.com> <1442482536-12024-4-git-send-email-he.chen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zf4Gp-0000Wg-Lo for xen-devel@lists.xenproject.org; Thu, 24 Sep 2015 11:00:59 +0000 In-Reply-To: <1442482536-12024-4-git-send-email-he.chen@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: He Chen , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, chao.p.peng@linux.intel.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-09-17 at 17:35 +0800, He Chen wrote: > diff --git a/tools/libxl/libxl_psr.c b/tools/libxl/libxl_psr.c > index 3378239..62963cf 100644 > --- a/tools/libxl/libxl_psr.c > +++ b/tools/libxl/libxl_psr.c > @@ -87,6 +87,9 @@ static void libxl__psr_cat_log_err_msg(libxl__gc *gc, > int err) > case EEXIST: > msg = "The same CBM is already set to this domain"; > break; > + case EINVAL: > + msg = "Unable to set code or data CBM when CDP is disabled"; > + break; These overloading of the errno values are getting a bit thinly stretched. The more so that EINVAL has a widely used more generic meaning. Hypervisor maintainers, what is your opinion of this? Since this is a sysctl I suppose we could consider adding a new PSR specific error type with appropriate codes?