From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 3/4] tools: add tools support for Intel
	CDP
Date: Thu, 24 Sep 2015 13:31:08 +0100
Message-ID: <1443097868.25250.8.camel@citrix.com>
References: <1442482536-12024-1-git-send-email-he.chen@linux.intel.com>
	<1442482536-12024-4-git-send-email-he.chen@linux.intel.com>
	<1443092450.10338.276.camel@citrix.com>
	<5603FFB302000078000A5446@prv-mh.provo.novell.com>
	<1443096462.25250.7.camel@citrix.com>
	<5604069402000078000A54D1@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7027b08fe=Ian.Campbell@citrix.com>)
	id 1Zf5g9-0005GX-3n
	for xen-devel@lists.xenproject.org; Thu, 24 Sep 2015 12:31:13 +0000
In-Reply-To: <5604069402000078000A54D1@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, He Chen <he.chen@linux.intel.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org, chao.p.peng@linux.intel.com, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-09-24 at 06:20 -0600, Jan Beulich wrote:
> > > > On 24.09.15 at 14:07, <ian.campbell@citrix.com> wrote:
> > On Thu, 2015-09-24 at 05:50 -0600, Jan Beulich wrote:
> > >  a specific error type
> > > to me seems to go too far. Surely out of the several dozen
> > > possibilities a handful of not-so-common ones can be picked?
> > 
> > I was thinking in particular EINVAL was not in the not-so-common
> > bracket.
> 
> Which I fully agree with.
> 
> > The current code already uses 9 values FWIW.
> 
> Right, but ENXIO would e.g. seem to be a reasonable fit for
> "Unable to set code or data CBM when CDP is disabled".

That would be better yes (sorry I didn't check if this came up in the
review of the hypervisor side)

Ian.