xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen: sched: rename vcpu_destroy perf counter to vcpu_remove
Date: Fri, 25 Sep 2015 09:40:36 +0200	[thread overview]
Message-ID: <1443166836.3276.40.camel@citrix.com> (raw)
In-Reply-To: <5604D12D.60508@suse.com>


[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]

On Fri, 2015-09-25 at 06:44 +0200, Juergen Gross wrote:
> On 09/24/2015 05:43 PM, Dario Faggioli wrote:
> > It seems this have had to be done as part of 7e6b926a
> > ("cpupools: Make interface more consistent"), which
> > renamed the function but not the counter.
> > 
> > In fact, because of cpupools, vcpus are not only removed
> > from a scheduler when they are destroyed, but also when
> > domains move between pools.
> > 
> > Make the related statistics counter reflect that more
> > properly.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> I'd change the following as well for the same reason:
> 
> vcpu_init -> vcpu_alloc_vdata
> 
Good point, I'll do that (although I may go for "vcpu_alloc" as a name)
.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

      reply	other threads:[~2015-09-25  7:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 15:43 [PATCH] xen: sched: rename vcpu_destroy perf counter to vcpu_remove Dario Faggioli
2015-09-25  4:44 ` Juergen Gross
2015-09-25  7:40   ` Dario Faggioli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443166836.3276.40.camel@citrix.com \
    --to=dario.faggioli@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgross@suse.com \
    --cc=mengxu@cis.upenn.edu \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).