From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] xen: sched: rename vcpu_destroy perf
 counter to vcpu_remove
Date: Fri, 25 Sep 2015 09:40:36 +0200
Message-ID: <1443166836.3276.40.camel@citrix.com>
References: <20150924154308.1262.24171.stgit@Solace.station>
	<5604D12D.60508@suse.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9157319893721417610=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7036a8607=dario.faggioli@citrix.com>)
	id 1ZfNcZ-0004wo-FX
	for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 07:40:43 +0000
In-Reply-To: <5604D12D.60508@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Meng Xu <mengxu@cis.upenn.edu>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

--===============9157319893721417610==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-m+Zhr/oN28pWJk/5Mp/r"

--=-m+Zhr/oN28pWJk/5Mp/r
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2015-09-25 at 06:44 +0200, Juergen Gross wrote:
> On 09/24/2015 05:43 PM, Dario Faggioli wrote:
> > It seems this have had to be done as part of 7e6b926a
> > ("cpupools: Make interface more consistent"), which
> > renamed the function but not the counter.
> >=20
> > In fact, because of cpupools, vcpus are not only removed
> > from a scheduler when they are destroyed, but also when
> > domains move between pools.
> >=20
> > Make the related statistics counter reflect that more
> > properly.
> >=20
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
>=20
> I'd change the following as well for the same reason:
>=20
> vcpu_init -> vcpu_alloc_vdata
>=20
Good point, I'll do that (although I may go for "vcpu_alloc" as a name)
.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-m+Zhr/oN28pWJk/5Mp/r
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYE+nQACgkQk4XaBE3IOsRy9gCfUFkkMAj6wRD9yb/e/Z8SwcRy
GDYAoIEWX4f64uz2DWNtxkH6x/KzKfU/
=TYxl
-----END PGP SIGNATURE-----

--=-m+Zhr/oN28pWJk/5Mp/r--


--===============9157319893721417610==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============9157319893721417610==--