From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v4 4/4] docs: add document to introduce CDP
 command
Date: Fri, 25 Sep 2015 10:58:58 +0100
Message-ID: <1443175138.25250.102.camel@citrix.com>
References: <1442482536-12024-1-git-send-email-he.chen@linux.intel.com>
	<1442482536-12024-5-git-send-email-he.chen@linux.intel.com>
	<1443093722.10338.292.camel@citrix.com> <20150925092933.GC12290@HE>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=703e89765=Ian.Campbell@citrix.com>)
	id 1ZfPmQ-0003uS-LD
	for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 09:59:02 +0000
In-Reply-To: <20150925092933.GC12290@HE>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: He Chen <he.chen@linux.intel.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, chao.p.peng@linux.intel.com, xen-devel@lists.xenproject.org, keir@xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-09-25 at 17:29 +0800, He Chen wrote:
> On Thu, Sep 24, 2015 at 12:22:02PM +0100, Ian Campbell wrote:
> > On Thu, 2015-09-17 at 17:35 +0800, He Chen wrote:
> > > Add new CDP options with CAT commands in xl interface man page.
> > > Add description of CDP in xl-psr.markdown.
> > 
> > It would have been fine to include this in the previous patch by the
> > way.
> > 
> 
> You mean include both xl man page and xl-psr.markdown in the previous
> patch? Or just only xl man page?

All of the docs could validly be included with the patch which introduces
the feature. i.e. you could fold patch #4 into #3 completely.

You don't have to if you don't want to.

> Maybe I make words a little confused here.
> With CDP enabled, user can specify code cache (or data cache) only, and
> the other would remain previous value (if no previous value, it would
> keep as default value).

The value is just enabled or disabled, so do I understand correctly that
this is what you can do if cdp is enabled:

    [now: code cbm=<default>; data cbm=<default>]

    xl psr-cat-cbm-set -c <domid> 0xdeadbeed
    [now: code cbm=0xdeadbeef; data cbm=<default>]

    xl psr-cat-cbm-set -d <domid> 0xf00fb00f
    [now: code cbm=0xdeadbeef; data cbm=0xf00fb00f]

    xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed

    [now: code cbm=0xd00dfeed; data cbm=0xd00dfeed]

    xl psr-cat-cbm-set <domid> 0xee11ee11

    [now: code cbm=0xee11ee11; data cbm=0xee11ee11]

Is that right?

And if cdp is not enabled:

    [now: cbm=<default>]

    xl psr-cat-cbm-set -c <domid> 0xdeadbeed
    *ERRROR*
    [now: cbm=<default>]

xl psr-cat-cbm-set -d <domid> 0xf00fb00f
    *ERRROR*
    [now: cbm=<default>]

xl psr-cat-cbm-set -c -d <domid> 0xd00dfeed

*ERRROR*
[now: cbm=<default>]

xl psr-cat-cbm-set <domid> 0xee11ee11

[now: cbm=0xee11ee11]

> So, I think independently would be fine here.

If I'm correct in all the above then yes.

Ian.