From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 2/8] xen/arm: io: Extend write/read handler to pass the register in parameter Date: Fri, 25 Sep 2015 17:36:11 +0100 Message-ID: <1443198971.25250.205.camel@citrix.com> References: <1443192698-16163-1-git-send-email-julien.grall@citrix.com> <1443192698-16163-3-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZfVz5-0007vC-7X for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 16:36:31 +0000 In-Reply-To: <1443192698-16163-3-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: Vijaya.Kumar@caviumnetworks.com, Julien Grall , stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com, vijay.kilari@gmail.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-09-25 at 15:51 +0100, Julien Grall wrote: > From: Julien Grall > > Rather than letting each handler to retrieve the register used by the > I/O access, add a new parameter to pass the register in parameter. > > This will help to implement generic register manipulation on I/O access > such as sign-extension and endianess. > > Read handlers need to modify the value of the register, so a pointer to > it is given in argument. Write handlers shouldn't modify the register, > therfore only a plain value is given. "therefore" > > Signed-off-by: Julien Grall Acked-by: Ian Campbell