From: Haozhong Zhang <haozhong.zhang@intel.com>
To: xen-devel@lists.xen.org
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Jan Beulich <jbeulich@suse.com>, Keir Fraser <keir@xen.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: [PATCH 07/13] x86/hvm: Move saving/loading vcpu's TSC to common code
Date: Mon, 28 Sep 2015 15:13:52 +0800 [thread overview]
Message-ID: <1443424438-13404-8-git-send-email-haozhong.zhang@intel.com> (raw)
In-Reply-To: <1443424438-13404-1-git-send-email-haozhong.zhang@intel.com>
Both VMX and SVM saves/loads vcpu's TSC when saving/loading vcpu's
context, so this patch moves saving/loading vcpu's TSC to the common
function hvm_save_cpu_ctxt()/hvm_load_cpu_ctxt().
Signed-off-by: Haozhong Zhang <haozhong.zhang@intel.com>
---
xen/arch/x86/hvm/hvm.c | 4 ++++
xen/arch/x86/hvm/svm/svm.c | 5 -----
xen/arch/x86/hvm/vmx/vmx.c | 5 -----
3 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index 568c9ef..3522d20 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1813,6 +1813,8 @@ static int hvm_save_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
/* Architecture-specific vmcs/vmcb bits */
hvm_funcs.save_cpu_ctxt(v, &ctxt);
+ ctxt.tsc = hvm_get_guest_tsc_fixed(v, d->arch.hvm_domain.sync_tsc);
+
ctxt.msr_tsc_aux = hvm_msr_tsc_aux(v);
hvm_get_segment_register(v, x86_seg_idtr, &seg);
@@ -2105,6 +2107,8 @@ static int hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
if ( !v->domain->arch.vtsc && hvm_funcs.tsc_scaling_supported )
hvm_setup_tsc_scaling(v);
+ hvm_set_guest_tsc_fixed(v, ctxt.tsc, d->arch.hvm_domain.sync_tsc);
+
v->arch.hvm_vcpu.msr_tsc_aux = ctxt.msr_tsc_aux;
seg.limit = ctxt.idtr_limit;
diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
index 0984021..73bc863 100644
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -357,9 +357,6 @@ static void svm_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
data->msr_syscall_mask = vmcb->sfmask;
data->msr_efer = v->arch.hvm_vcpu.guest_efer;
data->msr_flags = -1ULL;
-
- data->tsc = hvm_get_guest_tsc_fixed(v,
- v->domain->arch.hvm_domain.sync_tsc);
}
@@ -374,8 +371,6 @@ static void svm_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
vmcb->sfmask = data->msr_syscall_mask;
v->arch.hvm_vcpu.guest_efer = data->msr_efer;
svm_update_guest_efer(v);
-
- hvm_set_guest_tsc_fixed(v, data->tsc, v->domain->arch.hvm_domain.sync_tsc);
}
static void svm_save_vmcb_ctxt(struct vcpu *v, struct hvm_hw_cpu *ctxt)
diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 4edb099..624db1c 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -581,9 +581,6 @@ static void vmx_save_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
data->msr_lstar = guest_state->msrs[VMX_INDEX_MSR_LSTAR];
data->msr_star = guest_state->msrs[VMX_INDEX_MSR_STAR];
data->msr_syscall_mask = guest_state->msrs[VMX_INDEX_MSR_SYSCALL_MASK];
-
- data->tsc = hvm_get_guest_tsc_fixed(v,
- v->domain->arch.hvm_domain.sync_tsc);
}
static void vmx_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
@@ -598,8 +595,6 @@ static void vmx_load_cpu_state(struct vcpu *v, struct hvm_hw_cpu *data)
v->arch.hvm_vmx.cstar = data->msr_cstar;
v->arch.hvm_vmx.shadow_gs = data->shadow_gs;
-
- hvm_set_guest_tsc_fixed(v, data->tsc, v->domain->arch.hvm_domain.sync_tsc);
}
--
2.4.8
next prev parent reply other threads:[~2015-09-28 7:13 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 7:13 [PATCH 00/13] Add VMX TSC scaling support Haozhong Zhang
2015-09-28 7:13 ` [PATCH 01/13] x86/time.c: Use system time to calculate elapsed_nsec in tsc_get_info() Haozhong Zhang
2015-10-09 6:51 ` Jan Beulich
2015-10-09 13:41 ` Boris Ostrovsky
2015-10-09 14:00 ` Haozhong Zhang
2015-10-09 15:11 ` Jan Beulich
2015-10-09 16:09 ` Boris Ostrovsky
2015-10-09 16:19 ` Jan Beulich
2015-10-09 16:31 ` Boris Ostrovsky
2015-10-09 16:51 ` Haozhong Zhang
2015-10-09 18:59 ` Boris Ostrovsky
2015-10-09 14:39 ` Jan Beulich
2015-10-09 15:37 ` Boris Ostrovsky
2015-10-09 16:39 ` Haozhong Zhang
2015-10-09 16:44 ` Boris Ostrovsky
2015-10-09 14:35 ` Haozhong Zhang
2015-10-09 14:43 ` Jan Beulich
2015-10-09 15:56 ` Boris Ostrovsky
2015-10-14 2:45 ` Haozhong Zhang
2015-10-14 9:40 ` Jan Beulich
2015-10-14 10:00 ` Haozhong Zhang
2015-10-14 10:20 ` Jan Beulich
2015-10-14 10:24 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 02/13] x86/time.c: Get the correct guest TSC rate " Haozhong Zhang
2015-09-28 7:13 ` [PATCH 03/13] x86/hvm: Collect information of TSC scaling ratio Haozhong Zhang
2015-10-22 12:53 ` Jan Beulich
2015-10-22 14:40 ` Haozhong Zhang
2015-10-22 14:51 ` Jan Beulich
2015-10-22 15:57 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 04/13] x86/hvm: Setup " Haozhong Zhang
2015-10-22 13:13 ` Jan Beulich
2015-10-22 15:55 ` Haozhong Zhang
2015-10-22 16:05 ` Jan Beulich
2015-10-22 16:39 ` Haozhong Zhang
2015-10-23 7:44 ` Haozhong Zhang
2015-10-23 7:59 ` Jan Beulich
2015-10-23 8:18 ` Haozhong Zhang
2015-10-23 8:31 ` Jan Beulich
2015-10-23 8:40 ` Haozhong Zhang
2015-10-23 9:18 ` Jan Beulich
2015-09-28 7:13 ` [PATCH 05/13] x86/hvm: Replace architecture TSC scaling by a common function Haozhong Zhang
2015-10-22 13:52 ` Jan Beulich
2015-10-23 0:49 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 06/13] x86/hvm: Scale host TSC when setting/getting guest TSC Haozhong Zhang
2015-10-22 14:17 ` Jan Beulich
2015-10-22 15:44 ` Boris Ostrovsky
2015-10-22 16:23 ` Haozhong Zhang
2015-10-27 20:16 ` Aravind Gopalakrishnan
2015-10-28 1:51 ` Haozhong Zhang
2015-11-09 7:43 ` Haozhong Zhang
2015-11-12 13:50 ` George Dunlap
2015-10-22 16:03 ` Haozhong Zhang
2015-10-27 1:54 ` Haozhong Zhang
2015-10-27 8:15 ` Jan Beulich
2015-10-27 8:25 ` Haozhong Zhang
2015-10-27 8:44 ` Haozhong Zhang
2015-10-27 13:10 ` Boris Ostrovsky
2015-10-27 13:55 ` Boris Ostrovsky
2015-10-27 16:13 ` haozhong.zhang
2015-10-27 16:13 ` haozhong.zhang
2015-09-28 7:13 ` Haozhong Zhang [this message]
2015-10-22 14:54 ` [PATCH 07/13] x86/hvm: Move saving/loading vcpu's TSC to common code Jan Beulich
2015-09-28 7:13 ` [PATCH 08/13] x86/hvm: Detect TSC scaling through hvm_funcs in tsc_set_info() Haozhong Zhang
2015-10-22 15:01 ` Jan Beulich
2015-09-28 7:13 ` [PATCH 09/13] x86/time.c: Scale host TSC in pvclock properly Haozhong Zhang
2015-09-28 16:36 ` Boris Ostrovsky
2015-09-29 0:19 ` Haozhong Zhang
2015-10-22 15:50 ` Boris Ostrovsky
2015-10-22 16:44 ` Haozhong Zhang
2015-10-22 19:15 ` Boris Ostrovsky
2015-09-28 7:13 ` [PATCH 10/13] vmx: Detect and initialize VMX RDTSC(P) scaling Haozhong Zhang
2015-10-27 13:19 ` Jan Beulich
2015-10-27 16:17 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 11/13] vmx: Use scaled host TSC to calculate TSC offset Haozhong Zhang
2015-10-22 15:55 ` Boris Ostrovsky
2015-10-22 17:12 ` Haozhong Zhang
2015-10-22 19:19 ` Boris Ostrovsky
2015-10-23 0:52 ` Haozhong Zhang
2015-10-27 13:29 ` Jan Beulich
2015-10-27 16:21 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 12/13] vmx: Add a call-back to apply TSC scaling ratio to hardware Haozhong Zhang
2015-09-28 16:02 ` Boris Ostrovsky
2015-09-29 1:07 ` Haozhong Zhang
2015-09-29 9:33 ` Andrew Cooper
2015-09-29 10:02 ` Haozhong Zhang
2015-09-29 10:25 ` Andrew Cooper
2015-09-29 13:59 ` Haozhong Zhang
2015-10-27 13:33 ` Jan Beulich
2015-10-28 2:41 ` Haozhong Zhang
2015-09-28 7:13 ` [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate Haozhong Zhang
2015-09-28 11:47 ` Julien Grall
2015-09-28 12:11 ` Haozhong Zhang
2015-09-28 14:19 ` Wei Liu
2015-09-29 0:40 ` Haozhong Zhang
2015-09-29 9:20 ` Wei Liu
2015-09-29 9:50 ` Haozhong Zhang
2015-09-29 10:24 ` Julien Grall
2015-09-29 10:07 ` Ian Campbell
2015-09-29 10:33 ` Wei Liu
2015-09-29 12:57 ` Haozhong Zhang
2015-09-29 10:04 ` Ian Campbell
2015-09-29 10:13 ` Haozhong Zhang
2015-09-29 10:24 ` Andrew Cooper
2015-09-29 10:28 ` Ian Campbell
2015-09-29 10:31 ` Andrew Cooper
2015-09-29 13:53 ` Haozhong Zhang
2015-09-29 13:56 ` Andrew Cooper
2015-09-29 14:01 ` Haozhong Zhang
2015-09-29 14:37 ` Ian Campbell
2015-09-29 15:16 ` Haozhong Zhang
2015-09-28 10:51 ` [PATCH 00/13] Add VMX TSC scaling support Andrew Cooper
2015-09-28 13:48 ` Boris Ostrovsky
2015-11-22 17:54 ` Haozhong Zhang
2015-11-23 15:37 ` Boris Ostrovsky
2015-11-24 13:05 ` Haozhong Zhang
2015-11-24 14:19 ` Boris Ostrovsky
2015-11-24 14:25 ` Haozhong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443424438-13404-8-git-send-email-haozhong.zhang@intel.com \
--to=haozhong.zhang@intel.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).