From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for Xen 4.6 2/5] tools/libxl: fix socket display error for CMT Date: Mon, 28 Sep 2015 17:06:31 +0200 Message-ID: <1443452791.3276.81.camel@citrix.com> References: <1443441293-4287-1-git-send-email-chao.p.peng@linux.intel.com> <1443441293-4287-3-git-send-email-chao.p.peng@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8032386103057752912==" Return-path: In-Reply-To: <1443441293-4287-3-git-send-email-chao.p.peng@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chao Peng , xen-devel@lists.xen.org Cc: Ian.Jackson@eu.citrix.com, wei.liu2@citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============8032386103057752912== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-xAGStBTVZiNjRdF/M2sv" --=-xAGStBTVZiNjRdF/M2sv Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-09-28 at 19:54 +0800, Chao Peng wrote: > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 2706759..c72d3df 100644 > @@ -8228,9 +8228,9 @@ static void > psr_cmt_print_domain_info(libxl_dominfo *dominfo, > =20 > static int psr_cmt_show(libxl_psr_cmt_type type, uint32_t domid) > { > - uint32_t i, socketid, nr_sockets, total_rmid; > + uint32_t i, socketid, total_rmid; > uint32_t l3_cache_size; > - libxl_physinfo info; > + libxl_bitmap socketmap; > int rc, nr_domains; > =20 > if (!libxl_psr_cmt_enabled(ctx)) { > @@ -8244,41 +8244,38 @@ static int psr_cmt_show(libxl_psr_cmt_type > type, uint32_t domid) > return -1; > } > =20 > - libxl_physinfo_init(&info); > - rc =3D libxl_get_physinfo(ctx, &info); > + libxl_socket_bitmap_alloc(ctx, &socketmap, 0); > + rc =3D libxl_socket_bitmap_fill(ctx, &socketmap); > Shouldn't socketmap be initied with libxl_bitmap_init() before being allocated and used? Not doing so is certainly not an issue, in this case, but AFAIR, we always require that for libxl types, don't we? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-xAGStBTVZiNjRdF/M2sv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYJV3cACgkQk4XaBE3IOsS5TgCeKnnS9Ob7pkHRaMunILUci/y7 d78AnAvA9+yi46z6deGjfWKR2RrDqtqW =DGde -----END PGP SIGNATURE----- --=-xAGStBTVZiNjRdF/M2sv-- --===============8032386103057752912== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8032386103057752912==--