From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for Xen 4.6 0/5] Several PSR fixes in libxl Date: Mon, 28 Sep 2015 17:42:25 +0200 Message-ID: <1443454945.3276.105.camel@citrix.com> References: <1443441293-4287-1-git-send-email-chao.p.peng@linux.intel.com> <20150928141647.GG13821@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7762569808818046947==" Return-path: In-Reply-To: <20150928141647.GG13821@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Chao Peng Cc: xumengpanda@gmail.com, xen-devel@lists.xen.org, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============7762569808818046947== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-EpL9ps03UOkGtRDo/Auu" --=-EpL9ps03UOkGtRDo/Auu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-09-28 at 15:16 +0100, Wei Liu wrote: > On Mon, Sep 28, 2015 at 07:54:48PM +0800, Chao Peng wrote: > > The patch basically contains several PSR fixes in libxl. > > patch1-3: fix the socket display error in certain hotplug case. > > patch4: fix a minor range check. > > patch5: improve the PSR document. > >=20 > > Detailed problem and fix please see commit message. > >=20 >=20 > I've gone through all patches. This series looks sensible to me. And > I > see the point of getting in it for 4.6 to avoid releasing APIs that > are > deemed buggy. >=20 FWIW, I totally agree. The patch looks sensible to me too, I've only found a couple of minor issues. > I would still like some more proof reading from someone who have > played > with this feature. I've CCed Dario and Meng. >=20 Thanks for pinging... I've done my best. :-) About the suggestions I provided, the more important thing, IMO, is the name of the new function for retrieving the available sockets bitmap, which I really think it should be called libxl_get_online_socketmap().=20 The others are indeed minor things, which don't affect public APIs and hence --although I'd prefer to see them addressed-- we can fix/change them post 4.6 too. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-EpL9ps03UOkGtRDo/Auu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYJX+EACgkQk4XaBE3IOsQTmQCfdYv+iOUfdW2nasKuWcLJJdID ojgAn2rTwegXchR4yx1p7/lHXqph1r3V =CQUD -----END PGP SIGNATURE----- --=-EpL9ps03UOkGtRDo/Auu-- --===============7762569808818046947== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7762569808818046947==--