From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 4/8] xen/arm: Warn when a device tree path will be re-used by Xen Date: Mon, 28 Sep 2015 16:55:02 +0100 Message-ID: <1443455702.16718.3.camel@citrix.com> References: <1442944062-4324-1-git-send-email-julien.grall@citrix.com> <1442944062-4324-5-git-send-email-julien.grall@citrix.com> <1443197438.25250.186.camel@citrix.com> <56096054.5000102@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zgalf-0002Ev-Ou for xen-devel@lists.xenproject.org; Mon, 28 Sep 2015 15:55:07 +0000 In-Reply-To: <56096054.5000102@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-09-28 at 16:44 +0100, Julien Grall wrote: > > And that case does indeed seem worth warning about but the commit > > message > > needs to be clearer about the circumstances of the logging. > > What about: > > "Xen is using unconditionally some device tree path to create DOM0 "unconditionally using" and "paths", and probably s/some/certain/. > specific node (for instance /psci, /memory and /hypervisor). > > Print a warning message on the console to let know user the user if we "to let the user know" > re-use one of this node. "these nodes" > Note that the content of most those nodes are very common and they "most of those is" > should have already been skipped via the compatible string or type > string. This warning is here to catch buggy device-tree and compatible > string that we may not yet support in Xen." I don't think they are "buggy", perhaps more like "unusual". Ian