From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH for Xen 4.6 3/5] tools/libxl: return socket id from libxl_psr_cat_get_l3_info Date: Tue, 29 Sep 2015 09:19:08 +0200 Message-ID: <1443511148.3276.108.camel@citrix.com> References: <1443441293-4287-1-git-send-email-chao.p.peng@linux.intel.com> <1443441293-4287-4-git-send-email-chao.p.peng@linux.intel.com> <20150928141356.GD13821@zion.uk.xensource.com> <1443454556.3276.98.camel@citrix.com> <20150928154616.GO13821@zion.uk.xensource.com> <20150929030527.GF5813@pengc-linux.bj.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8218119372476707625==" Return-path: In-Reply-To: <20150929030527.GF5813@pengc-linux.bj.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chao Peng , Wei Liu Cc: xen-devel@lists.xen.org, g@zion.uk.xensource.com, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============8218119372476707625== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-XE3cAVj/lY/+G2H/hAfL" --=-XE3cAVj/lY/+G2H/hAfL Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-09-29 at 11:05 +0800, Chao Peng wrote: > On Mon, Sep 28, 2015 at 04:46:17PM +0100, Wei Liu wrote: > > On Mon, Sep 28, 2015 at 05:35:56PM +0200, Dario Faggioli wrote: > > > But since now you're building the full bitmap, we can use > > > libxl_bitmap_count_set(), for that. > > >=20 > > > This may not be a bit deal, but if I'm not wrong, it saves us an > > > hypercall (the PHYSINFO that libxl__count_physical_socket() > > > issues). > > >=20 >=20 > I can pass 0 to libxl_socket_bitmap_alloc() but it will call > hypercall > internally. We need the size for the socketmap anyway before we > allocating it. >=20 Yes, looking better, the number of hypercall we need seems the same in both cases. Furthermore, as Wei said, this is an internal detail / optimization that we can always look into in future, so nevermind, do as you like best. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-XE3cAVj/lY/+G2H/hAfL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYKO2wACgkQk4XaBE3IOsSOeACgiUo0sj4C3EQlsrcQi2vOyth3 N1gAniThEc/EM8CpNFzcPtyzAPYr9Cqs =ZfdP -----END PGP SIGNATURE----- --=-XE3cAVj/lY/+G2H/hAfL-- --===============8218119372476707625== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8218119372476707625==--