From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH] ts-hosts-allocate-Executive: Do not allocate specific host with wrong blessing Date: Tue, 29 Sep 2015 15:30:43 +0100 Message-ID: <1443537043.16718.107.camel@citrix.com> References: <1443536078-23449-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zgvw6-0005RP-00 for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 14:31:18 +0000 In-Reply-To: <1443536078-23449-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-29 at 15:14 +0100, Ian Jackson wrote: > If the job contains a runvar specifying a specific host, still check > that host's blessing. Otherwise bisections can run on unblessed > hosts. They should fail instead. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell > if (!@candidates) { > if (defined $use) { > - logm("specified host $use for $hid->{Ident} nonexistent?"); > + logm("specified host $use for $hid->{Ident} nonexistent or unblessed?"); Strange indent due to the length of the message, rather than by mistake, I suppose? Ian.