From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 2/1] ts-hosts-allocate-Executive: Finish a couple of transactions Date: Tue, 29 Sep 2015 17:03:03 +0100 Message-ID: <1443542583.16718.136.camel@citrix.com> References: <1443536078-23449-1-git-send-email-ian.jackson@eu.citrix.com> <1443540459-31266-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZgxWm-0002zz-DX for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 16:13:16 +0000 In-Reply-To: <1443540459-31266-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-29 at 16:27 +0100, Ian Jackson wrote: > Call $equivflagscheckq->finish() at the end, rather than in the > candidate search loop. This avoids missing a `next' control path. > > Call $resprop_q->finish() at all. > > One of these is responsible for this message: > > DBI::db=HASH(0x88e79c4)->disconnect invalidates 1 active statement > handle (either destroy statement handles or call finish on them > before disconnecting) at Osstest/Executive.pm line 708, line > 53. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell