From: Ian Campbell <ian.campbell@citrix.com>
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack
Date: Wed, 30 Sep 2015 09:32:57 +0100 [thread overview]
Message-ID: <1443601977.16718.152.camel@citrix.com> (raw)
In-Reply-To: <1443455775-26131-2-git-send-email-anthony.perard@citrix.com>
On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> + # OpenStack needs access to libvirt from a user.
> + target_cmd_root($ho, <<END);
> + cat >> /etc/libvirt/libvirtd.conf <<EOF
> +unix_sock_group = "libvirt"
> +unix_sock_ro_perms = "0777"
> +unix_sock_rw_perms = "0770"
> +EOF
> +END
One small nit on this, which is that it isn't idempotent, i.e. running this
step on the same host repeatedly (common in standalone mode) will keep
adding those lines to the conf file.
If you care then possible solutions:
Use target_editfile_root() to filter the lines out and then re-add them.
See setupboot_grub2 and the handling of GRUB_ENABLE_XEN_UEFI_CHAINLOAD
Use grep (3 times?) to decide if you need to append the given line.
Modify the file in the dist file in ts-libvirt-build so it applies to all
test cases and not just this one.
Ian.
next prev parent reply other threads:[~2015-09-30 8:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 15:56 [PATCH OSSTEST v3 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
2015-09-28 15:56 ` [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
2015-09-29 15:34 ` Ian Campbell
2015-09-29 16:19 ` Anthony PERARD
2015-09-29 17:04 ` Ian Jackson
2015-09-30 8:29 ` Ian Campbell
2015-09-29 17:02 ` Ian Jackson
2015-09-30 8:32 ` Ian Campbell [this message]
2015-09-30 10:52 ` Ian Jackson
2015-09-28 15:56 ` [PATCH OSSTEST v3 2/3] ts-openstack-tempest: Run Tempest to check OpenStack Anthony PERARD
2015-09-29 15:43 ` Ian Campbell
2015-09-29 17:15 ` Anthony PERARD
2015-09-30 8:38 ` Ian Campbell
2015-09-28 15:56 ` [PATCH OSSTEST v3 3/3] Create a flight to test OpenStack with xen-unstable and libvirt Anthony PERARD
2015-09-29 15:49 ` Ian Campbell
2015-09-29 17:21 ` Anthony PERARD
2015-09-29 16:52 ` Ian Jackson
2015-10-08 16:08 ` Ian Campbell
2015-10-08 16:42 ` Ian Jackson
2015-10-09 10:54 ` Anthony PERARD
2015-10-13 11:02 ` Ian Jackson
2015-10-13 11:39 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443601977.16718.152.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=anthony.perard@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).