From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 for Xen 4.6 5/6] docs: make xl-psr.markdown more precise Date: Wed, 30 Sep 2015 09:57:31 +0100 Message-ID: <1443603451.16718.167.camel@citrix.com> References: <1443512995-11853-1-git-send-email-chao.p.peng@linux.intel.com> <1443512995-11853-6-git-send-email-chao.p.peng@linux.intel.com> <560A596D.7020201@citrix.com> <1443520540.16718.25.camel@citrix.com> <20150930013435.GH5813@pengc-linux.bj.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150930013435.GH5813@pengc-linux.bj.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chao Peng Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, Andrew Cooper , dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, lars.kurth@ctrix.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-09-30 at 09:34 +0800, Chao Peng wrote: > On Tue, Sep 29, 2015 at 10:55:40AM +0100, Ian Campbell wrote: > > On Tue, 2015-09-29 at 10:27 +0100, Andrew Cooper wrote: > > > On 29/09/15 08:49, Chao Peng wrote: > > > > [1] Intel SDM > > > > -(http://www.intel.com/content/www/us/en/processors/architectures-s > > > > oftw > > > > are-developer-manuals.html). > > > > +(http://www.intel.com/content/dam/www/public/us/en/documents/manua > > > > ls/6 > > > > 4-ia-32-architectures-software-developer-system-programming-manual > > > > -325384.pdf). > > > > > > The other two changes look fine, but this change now points to a > > > specific instance of the SDM, not the most recent version. I would > > > leave the link as it previously was. > > > > I agree, we either want a specific revision with specific chapter > > numbers > > _or_ an up to date revision with just the titles and no specific > > chapter > > numbers. This commit removes the chapter numbers but switches to a > > specific > > revision, which is undesirable IMHO. > > > > I therefore intend to drop this last hunk during commit. > > I feel confortable, too. Thanks for confirming. > Actually this is a suggestion from Lars during > he reviewing the documents for the 4.6 release. Because when one opens > the generic page he/she will see several options (combined volume set, > three-volume set and seven-volume set), it may be not easy to find out > the related chapters and especially because we have chapter number which > is actually from the three-volume set, in such case it does look a bit > confusing. Right. Would it be worth mentioning the specific volume which is of interest as a guide? > > As now we have removed the chapter number, then the confusion doesn't > exit because one can grab any volume set and will find the related > chapters. I think this addressed Lars' concern. > > Chao >