From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 5/9] xen: sched: make implementing
 .alloc_pdata optional
Date: Thu, 1 Oct 2015 08:35:30 +0200
Message-ID: <1443681330.3276.166.camel@citrix.com>
References: <20150929164726.17589.96920.stgit@Solace.station>
	<20150929165604.17589.24387.stgit@Solace.station>
	<560CC46D.8050002@suse.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6919474264178734798=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=709fabeff=dario.faggioli@citrix.com>)
	id 1ZhXSt-0006d8-2P
	for xen-devel@lists.xenproject.org; Thu, 01 Oct 2015 06:35:39 +0000
In-Reply-To: <560CC46D.8050002@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Josh Whitehead <josh.whitehead@dornerworks.com>, Robert VanVossen <robert.vanvossen@dornerworks.com>
List-Id: xen-devel@lists.xenproject.org

--===============6919474264178734798==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-pof37C7KOSgt0YVkdAEs"

--=-pof37C7KOSgt0YVkdAEs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-10-01 at 07:28 +0200, Juergen Gross wrote:
> On 09/29/2015 06:56 PM, Dario Faggioli wrote:

> > --- a/xen/common/schedule.c
> > +++ b/xen/common/schedule.c
> > @@ -1501,8 +1501,8 @@ int schedule_cpu_switch(unsigned int cpu,
> > struct cpupool *c)
> >           return 0;
> >=20
> >       idle =3D idle_vcpu[cpu];
> > -    ppriv =3D SCHED_OP(new_ops, alloc_pdata, cpu);
> > -    if ( ppriv =3D=3D NULL )
> > +    if ( (new_ops->alloc_pdata !=3D NULL) &&
> > +         ((ppriv =3D new_ops->alloc_pdata(new_ops, cpu)) =3D=3D NULL) =
)
> >           return -ENOMEM;
> >       vpriv =3D SCHED_OP(new_ops, alloc_vdata, idle, idle->domain
> > ->sched_priv);
> >       if ( vpriv =3D=3D NULL )
>=20
> Just below this there are 2 SCHED_OP calls to free_pdata. You'll have
> to
> check whether the hook is present as you just have nuked it above.
>=20
I think this is fine, for the same reasons explained when replying to
your comment to patch 4.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-pof37C7KOSgt0YVkdAEs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYM1DIACgkQk4XaBE3IOsTNogCghyzVY/xSm59m4LA/l+aRmG27
eq8AoIdKBjPnF6jc9xDc0JVHyMHPy43P
=m5rk
-----END PGP SIGNATURE-----

--=-pof37C7KOSgt0YVkdAEs--


--===============6919474264178734798==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6919474264178734798==--