Re: [PATCH 2/9] xen: sched: improve scope and placement of credit2 boot parameters

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1784 bytes --]

On Thu, 2015-10-01 at 01:51 -0600, Jan Beulich wrote:
> > > > On 29.09.15 at 18:55, <dario.faggioli@citrix.com> wrote:
> > --- a/xen/common/sched_credit2.c
> > +++ b/xen/common/sched_credit2.c
> > @@ -162,7 +162,7 @@
> >  #define CSFLAG_runq_migrate_request
> > (1<<__CSFLAG_runq_migrate_request)
> >  
> >  
> > -int opt_migrate_resist=500;
> > +static int __read_mostly opt_migrate_resist = 500;
> >  integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
> >  
> >  /*
> > @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist",
> > opt_migrate_resist);
> >   *   to a load of 1.
> >   */
> >  #define LOADAVG_GRANULARITY_SHIFT (10)
> > -int opt_load_window_shift=18;
> > +static int __read_mostly opt_load_window_shift = 18;
> >  #define  LOADAVG_WINDOW_SHIFT_MIN 4
> >  integer_param("credit2_load_window_shift", opt_load_window_shift);
> > -int opt_underload_balance_tolerance=0;
> > +static int __read_mostly opt_underload_balance_tolerance = 0;
> >  integer_param("credit2_balance_under",
> > opt_underload_balance_tolerance);
> > -int opt_overload_balance_tolerance=-3;
> > +static int __read_mostly opt_overload_balance_tolerance = -3;
> >  integer_param("credit2_balance_over",
> > opt_overload_balance_tolerance);
> 
> Are all of these validly _signed_ int? If not, I think adjusting
> their
> types here would be quite appropriate.
> 
Good point. Since I'm touching them, I'll convert to 'unsigned int' som
e of them

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel