From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 2/9] xen: sched: improve scope and placement of credit2 boot parameters Date: Thu, 1 Oct 2015 10:17:25 +0200 Message-ID: <1443687445.3276.205.camel@citrix.com> References: <20150929164726.17589.96920.stgit@Solace.station> <20150929165542.17589.15471.stgit@Solace.station> <560D022102000078000A7547@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4213258564426685012==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZhZ3U-0002qf-3O for xen-devel@lists.xenproject.org; Thu, 01 Oct 2015 08:17:32 +0000 In-Reply-To: <560D022102000078000A7547@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , xen-devel@lists.xenproject.org, Uma Sharma List-Id: xen-devel@lists.xenproject.org --===============4213258564426685012== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-aIo1YV/bCCJxw5oM+91h" --=-aIo1YV/bCCJxw5oM+91h Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2015-10-01 at 01:51 -0600, Jan Beulich wrote: > > > > On 29.09.15 at 18:55, wrote: > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -162,7 +162,7 @@ > > #define CSFLAG_runq_migrate_request > > (1<<__CSFLAG_runq_migrate_request) > > =20 > > =20 > > -int opt_migrate_resist=3D500; > > +static int __read_mostly opt_migrate_resist =3D 500; > > integer_param("sched_credit2_migrate_resist", opt_migrate_resist); > > =20 > > /* > > @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", > > opt_migrate_resist); > > * to a load of 1. > > */ > > #define LOADAVG_GRANULARITY_SHIFT (10) > > -int opt_load_window_shift=3D18; > > +static int __read_mostly opt_load_window_shift =3D 18; > > #define LOADAVG_WINDOW_SHIFT_MIN 4 > > integer_param("credit2_load_window_shift", opt_load_window_shift); > > -int opt_underload_balance_tolerance=3D0; > > +static int __read_mostly opt_underload_balance_tolerance =3D 0; > > integer_param("credit2_balance_under", > > opt_underload_balance_tolerance); > > -int opt_overload_balance_tolerance=3D-3; > > +static int __read_mostly opt_overload_balance_tolerance =3D -3; > > integer_param("credit2_balance_over", > > opt_overload_balance_tolerance); >=20 > Are all of these validly _signed_ int? If not, I think adjusting > their > types here would be quite appropriate. >=20 Good point. Since I'm touching them, I'll convert to 'unsigned int' som e of them Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-aIo1YV/bCCJxw5oM+91h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYM7BUACgkQk4XaBE3IOsT2SgCfbhRbAVHhBKSlOAS+0JZSpP7u w00AnidY2FPjbGIGnUMrCHscw1u81Ipe =OL9D -----END PGP SIGNATURE----- --=-aIo1YV/bCCJxw5oM+91h-- --===============4213258564426685012== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4213258564426685012==--