From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 4/9] xen: sched: add .init_pdata hook to the
 scheduler interface
Date: Thu, 1 Oct 2015 11:40:29 +0200
Message-ID: <1443692429.3276.246.camel@citrix.com>
References: <20150929164726.17589.96920.stgit@Solace.station>
	<20150929165556.17589.62924.stgit@Solace.station>
	<560CC2EC.6030801@suse.com> <1443681197.3276.163.camel@citrix.com>
	<560CE43F.3030809@suse.com> <560CFDBD.4090005@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9119655589100240269=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=709fabeff=dario.faggioli@citrix.com>)
	id 1ZhaLr-0004GK-Db
	for xen-devel@lists.xenproject.org; Thu, 01 Oct 2015 09:40:35 +0000
In-Reply-To: <560CFDBD.4090005@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org, George Dunlap <george.dunlap@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============9119655589100240269==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-eUQfHqpPJz7C9G8FJ1jb"

--=-eUQfHqpPJz7C9G8FJ1jb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-10-01 at 10:32 +0100, Andrew Cooper wrote:
> On 01/10/15 08:43, Juergen Gross wrote:
> > On 10/01/2015 08:33 AM, Dario Faggioli wrote:
> > > On Thu, 2015-10-01 at 07:21 +0200, Juergen Gross wrote:

> > > #define SCHED_OP(opsptr, fn,
> > > ...)                                          \
> > >           (( (opsptr)->fn !=3D NULL ) ? (opsptr)->fn(opsptr,
> > > ##__VA_ARGS__ )  \
> > >            : (typeof((opsptr)->fn(opsptr, ##__VA_ARGS__)))0 )
> >=20
> > Aah, yes, of course.
> >=20
> > Sorry for the noise.
>=20
> Another area ripe for cleanup is these macros.  As far as I can tell,
> they serve no purpose other than to obscure the code, stop
> cscope/ctags
> from following the calls, and give the preprocessor a headache.
>=20
> A system like we use for the hvm_func pointers and the static inline
> wrappers would be far clearer, and also make it obvious that it is
> safe
> to call with a NULL function pointer.
>=20
Happy to add this as well to my TODO list. :-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-eUQfHqpPJz7C9G8FJ1jb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYM/40ACgkQk4XaBE3IOsQrpACeOn6VE36045kMkt8ebBRDqMLE
I34AniSg9gDG0AtNtZQbCIyp1icE55lE
=AEGa
-----END PGP SIGNATURE-----

--=-eUQfHqpPJz7C9G8FJ1jb--


--===============9119655589100240269==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============9119655589100240269==--