xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com
Subject: Re: [PATCH v2 3/3] xen/arm: io: Shorten the name of the fields and clean up
Date: Thu, 1 Oct 2015 13:41:43 +0100	[thread overview]
Message-ID: <1443703303.11707.35.camel@citrix.com> (raw)
In-Reply-To: <1443537881-6816-4-git-send-email-julien.grall@citrix.com>

On Tue, 2015-09-29 at 15:44 +0100, Julien Grall wrote:
> The field names in the IO emulation are really long and use repeatedly
> the term handler which make some line cumbersome to read:
> 
> mmio_handler->mmio_handler_ops->write_handler
> 
> Also take the opportunity to do some clean up:
>     - Avoid "handler" vs "handle" in register_mmio_handler
>     - Use a local variable to initialize handler in
>     register_mmio_handler
>     - Add a comment explaining the dsb(ish) in register_mmio_handler
>     - Rename the structure io_handler into vmmio because the io_handler
>     is in fine handling multiple handlers and the name a the fields was
>     io_handlers. Also rename the field io_handlers to vmmio
>     - Rename the field mmio_handler_ops to ops because we are in the
>     structure mmio_handler to not need to repeat it
>     - Rename the field mmio_handlers to handlers because we are in the
>     vmmio structure
>     - Make it clear that register_mmio_ops is taking an ops and not an
>     handle
>     - Clean up local variable to help to understand the code
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> 
> ---
>     This is the last patch of the series so to make easy to backport the
>     previous patches to Xen 4.6 if necessary.
> 
>     Ian, I haven't kept your acked-by because I had to rebase after the
>     changes you requested on patch #1.

No problem, for something like that I wouldn't have minded if you had kept
it. In any case this version:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

  reply	other threads:[~2015-10-01 12:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 14:44 [PATCH v2 0/3] xen/arm vgic-v3: Correctly retrieved the vCPU associated to a re-distributor Julien Grall
2015-09-29 14:44 ` [PATCH v2 1/3] xen/arm: io: Extend write/read handler to pass private data Julien Grall
2015-10-01 12:40   ` Ian Campbell
2015-09-29 14:44 ` [PATCH v2 2/3] xen/arm: vgic-v3: Correctly retrieve the vCPU associated to a re-distributor Julien Grall
2015-09-29 14:44 ` [PATCH v2 3/3] xen/arm: io: Shorten the name of the fields and clean up Julien Grall
2015-10-01 12:41   ` Ian Campbell [this message]
2015-10-01 12:56 ` [PATCH v2 0/3] xen/arm vgic-v3: Correctly retrieved the vCPU associated to a re-distributor Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443703303.11707.35.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).